Bug 19323 - [Preferences] Import/Export Preferences shouldn't close preference page
Summary: [Preferences] Import/Export Preferences shouldn't close preference page
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: Other other
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2002-06-05 10:22 EDT by Jared Burns CLA
Modified: 2006-06-22 08:34 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2002-06-05 10:22:34 EDT
Summary says it all. When a user imports some preferences, they're not 
necessarily done with the dialog. For example, they may want to view/modify 
preferences that they imported from a colleague.
Comment 1 Nick Edgar CLA 2002-06-05 11:21:24 EDT
Agree.
Comment 2 Randy Giffen CLA 2002-06-07 09:02:54 EDT
But the dialog is in an invalid state.
Consider
1) Open the dialog 
2) Change some preference
3) Export
You want export to export your change so we do a performOK before the export.
This means that you can no longer cancel so the dialog is closed

1) Open the dialg
2) Import some prefences
3) The page in the dialog does not show the imported state, if you hit OK we 
will save the old state in the page.

These complications arise from overloading the dialog with the import/export 
actions. 
Comment 3 Nick Edgar CLA 2002-06-07 09:28:03 EDT
Not critical for 2.0. 
Defer for reconsideration later.
Comment 4 Randy Giffen CLA 2002-08-12 10:46:31 EDT
Reopened for investigation
Comment 5 Tod Creasey CLA 2002-08-26 15:17:22 EDT
If we were to change this behaviour we would force the developers of 
preference pages to handle property change events to get this. This would be a 
lot of extra work and should only be done if it is really a big win for 
usability.
Comment 6 Jared Burns CLA 2002-08-26 15:54:48 EDT
How about just reopening the preference dialog?
Comment 7 Jared Burns CLA 2002-09-03 15:01:47 EDT
Note that the same applies to the Export button. If we have to close the 
dialog because of some implementation problem, we should reopen the dialog 
to put the user back where they started.

As a quick hack, I tossed the code from OpenPreferencesAction.run() in at 
the end of WorkbenchPreferenceDialog.loadPressed() and it achieved the 
desired effect. After the import, the dialog closed then reopened with the 
new values.

Ideally, the dialog could do something like dispose of the existing 
preference pages when the user imports and then recreate the pages (thus 
pulling in the new values) as necessary. Short of this, closing/reopening 
the page is an improvement.
Comment 8 Didier Dubois CLA 2002-12-20 04:32:11 EST
My 2Cts:
May be the Window type for the prefeence is not the most accurate one. 

Since there is a lot of information on this window (And it will grow 
certainly), why not consider using the "standard" Perspectives/Views paradigm?

For instance one could have a Navigator on the Left showing the different 
options/preferences, and the details on the right (one could even imagine a GUI 
view and XML or Text additionals view)

This way, the Export/Import buttons could appear on a menu for instance.
One could even imagine importing/exporting only fragments of the Preferences...

Regards,
Didier.

PS: I hope I didn't disturb you with those lines.
Comment 9 Tod Creasey CLA 2006-06-22 08:34:23 EDT
There are currently no plans to work on this feature