Community
Participate
Working Groups
The ..mylyn.team.ui plug-in should be generic and not coupled to a specific team provider.
Can you please remind me if I have permissions for *team plugins? LinkedTaskInfoAdapterFactory need to be split into two separate ones.
That makes sense, would be great if you could do that. Can't check now but if I recall you were supposed to have commit rights on team. Everything has changed from the move, so hopefully you still do.
(In reply to comment #1) > Can you please remind me if I have permissions for *team plugins? > LinkedTaskInfoAdapterFactory need to be split into two separate ones. Fyi I checked and we do not have those commit permissions on record for you.
Created attachment 70950 [details] split adapter factory This patch moves dependencies from adapter factory into a separate plugin (also moved factory initialization into plugin.xml). However there is another dependency on CVS plugin from ContextChangeSet class.
Created attachment 70951 [details] mylar/context/zip
Patch applied, thanks Eugene. To complete this I will also need to remove our dependency on CVSActiveChangeSet (see comment#20 on bug 142395). That will have to wait post 2.0. What's good is that we have the plug-in split for Europa since it is likely that we will be able to keep the APIs the same.
Will explore for 2.2.
Needs to wait until 2.3 or 3.0.
Created attachment 91569 [details] removed dependency on team.cvs.core Here is summary of changes - changed binding of mylyn actions for synchronize view common navigator to ILinkedTaskInfo - replaced adapting ContextChangeSet to ResourceMapping with new adapter factory contributed by mylyn.team.cvs
Created attachment 91570 [details] mylyn/context/zip
need more work
Will review post EclipseCon.
Eugene: I was able to use some parts of your patch, although I reworked a bunch of it. The change to LinkedTaskInfo did not work as expected because we invoke the comment check. To address this Steffen and I changed ContextChangeSet. Also, just fyi we change the adapter access to avoid use of internals: return AdapterManager.getDefault().getAdapter(this, adapter); To: return Platform.getAdapterManager().getAdapter(this, adapter); The more major change we did as part of this is listed under the "Changed Team API" section of the porting guide. ILinkedTaskInfo is now AbstractTaskReference with a getText() method for textual references (e.g. comments, messages). We moved it out of tasks.core because we don't know of any clients outside of team plug-ins. Do you have any clients that need to access it from tasks.core?
Created attachment 96536 [details] mylyn/context/zip
The commit action is now missing from CVS changesets in the synchronize perspective. Mik, we need to revisit the decision to use ActiveChangeSet instead of CvsActiveChangeSet.
Fixed by adding a new mapping. Still need to verify things in non-models mode.
Mik, thanks for the update. Though it is very unfortunate that you have chanced API for ILinkedTaskInfo. This will require to update team integrations, which wasn't really expected. I am not sure when I'll have chance to update Subclipse implementation for this.
We realize the pains of making integrators update, and regarding the Team APIs, we left them unchanged for Mylyn 2.0 for this reason. But we are planning on making Mylyn 3.0 the last major API revision, and as such it is important that we prioritize API quality this time around. We will provide very clear porting guide steps for making the change.
API work is done. Assuming that the changes support fixing the refresh problems that they added, which we'll fix via bug 142280, we're done here.
