Bug 191524 - [Viewers] Synchronize horizontal scrolling by # characters, not % of longest line
Summary: [Viewers] Synchronize horizontal scrolling by # characters, not % of longest ...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-07 13:23 EDT by Matt McCutchen CLA
Modified: 2007-08-10 07:23 EDT (History)
1 user (show)

See Also:


Attachments
Change scrolling to # pixels (1.37 KB, patch)
2007-06-07 13:29 EDT, Matt McCutchen CLA
no flags Details | Diff
mylar/context/zip (3.50 KB, application/octet-stream)
2007-06-07 13:29 EDT, Matt McCutchen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen CLA 2007-06-07 13:23:50 EDT
Build ID: HEAD as of 6/7/2007

Horizontal scrolling in text compare editors is synchronized by percent of the text widget width, i.e., percent of the longest line.  This means that if two files are similar except that the second has an extremely long line, the second will scroll much faster than the first, making it more difficult to view corresponding portions of the other lines.  I think the scrolling should be synchronized by number of characters.

Steps To Reproduce:
1. Start Eclipse on a new workspace and make a new project.
2. In the project, create a file "a" containing a single line of about 100 characters ending with "foo".
3. Copy "a" to "b", but change the "foo" to "bar".
4. At the end of "b", add a line of about 500 characters.
5. Select "a" and "b" -> Compare With -> Each Other.
6. Slowly scroll the left pane to the right by dragging the scrollbar.  Notice that the text in the right pane goes by much more quickly.  In particular, the right pane scrolls past "bar" before the left pane reaches "foo".
Comment 1 Matt McCutchen CLA 2007-06-07 13:29:45 EDT
Created attachment 70534 [details]
Change scrolling to # pixels

This patch makes the scrolling synchronized by number of pixels, which is probably close enough to number of characters.
Comment 2 Matt McCutchen CLA 2007-06-07 13:29:47 EDT
Created attachment 70535 [details]
mylar/context/zip
Comment 3 Michael Valenta CLA 2007-06-11 13:50:29 EDT
Thanks for the patch.
Comment 4 Michael Valenta CLA 2007-07-18 10:57:29 EDT
Patch released to HEAD. Thanks.
Comment 5 Szymon Brandys CLA 2007-08-10 07:23:40 EDT
Verified in build I20070808-1800