Bug 191432 - [spell checking] Allow to spell check projects
Summary: [spell checking] Allow to spell check projects
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement with 5 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 275532 314042 318677 433468 471159 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-07 04:24 EDT by Benno Baumgartner CLA
Modified: 2018-02-13 10:04 EST (History)
10 users (show)

See Also:


Attachments
Proposed fix (53.87 KB, patch)
2009-06-17 09:51 EDT, Benno Baumgartner CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2007-06-07 04:24:48 EDT
I20070606-0010

I would like to be able to select a set of resources and have an action like:
'Find spelling Errors'
A view should show all errors found (could be the search view, could be a separate view). The view should allow to goto the spelling error and add words to the user dict.

Reason: I'm spell checking the help at the moment, which means I have to open each file in an editor, which is pain full.

Hint: I know eclipse is not an office suite, but I think this is a low hanging fruit.
Comment 1 Dani Megert CLA 2009-05-11 11:51:39 EDT
*** Bug 275532 has been marked as a duplicate of this bug. ***
Comment 2 Benno Baumgartner CLA 2009-06-17 09:51:44 EDT
Created attachment 139425 [details]
Proposed fix

This patch implements the request.

A search page is added allowing to:
  - Choose the file name pattern of the files to check
  - Choose the search scope (selection, workspace, working set, enclosing project)
  - Choose the spelling engine (if more then one is available)

A search result page shows the result. The page has the same features as the text search result view, including colored labels, and tree/table view. In addition actions are provided to:
  - Fix spelling problems

This is product quality code, but, to be able to provide such a small patch with such a rich feature set it is required to reuse tons of code from the text file search. Most of this code is internal, and hence, the spelling search must live in the org.eclipse.search plugin, if we don't want to provide additional API (which I guess we don't).

Things to do:
 - Search page should remember last selections
 - Spelling Problem Search icon
 - Tests?
Comment 3 Benno Baumgartner CLA 2009-06-17 09:53:06 EDT
Dani, I don't know if platform/text resp. platform/search is interested in this. If yes I can work on it.
Comment 4 Dani Megert CLA 2009-06-19 03:11:07 EDT
Discussed with Benno. Searching for spelling errors sounds odd especially since we already report them while typing. We should handle this like any other problem being reported in the Problems view along with quick fixes and even multi-quick fixes. Hence the right approach is to add a builder that reports the spelling problems as markers.
Comment 5 Dani Megert CLA 2010-05-25 02:34:22 EDT
*** Bug 314042 has been marked as a duplicate of this bug. ***
Comment 6 Dani Megert CLA 2010-07-05 01:29:19 EDT
*** Bug 318677 has been marked as a duplicate of this bug. ***
Comment 7 Deepak Azad CLA 2010-11-10 00:28:55 EST
(In reply to comment #0)
> Reason: I'm spell checking the help at the moment, which means I have to open
> each file in an editor, which is pain full.
This is indeed painful! (even though we do this only once or twice a year).

(In reply to comment #4)
> Discussed with Benno. Searching for spelling errors sounds odd especially since
> we already report them while typing. We should handle this like any other
> problem being reported in the Problems view along with quick fixes and even
> multi-quick fixes. Hence the right approach is to add a builder that reports
> the spelling problems as markers.
We also have 'Find broken externalized strings' in JDT which finds problems on demand. Adding a builder would mean that spelling problems are reported all the time, which means workspace build time would increase something I do not want. Unless of course the spell check builder can be turned on and off... :)
Comment 8 Dani Megert CLA 2010-11-10 04:01:33 EST
> Unless of course the spell check builder can be turned on and off... :)
Every builder can be turned off, see project properties > Builders.
Comment 9 Deepak Azad CLA 2010-11-10 04:19:02 EST
(In reply to comment #8)
> > Unless of course the spell check builder can be turned on and off... :)
> Every builder can be turned off, see project properties > Builders.
I see. I was looking for a workspace wide setting...
Comment 10 Dani Megert CLA 2014-04-25 05:41:57 EDT
*** Bug 433468 has been marked as a duplicate of this bug. ***
Comment 11 Dani Megert CLA 2015-07-21 08:51:01 EDT
*** Bug 471159 has been marked as a duplicate of this bug. ***
Comment 12 Stephen Lawson CLA 2018-02-13 10:04:41 EST
A project wide spellcheck would be really useful. When you pickup legacy code a global search would be really helpful.