Bug 191364 - [Proxy Preferences] Edit, Delete buttons enabled improperly
Summary: [Proxy Preferences] Edit, Delete buttons enabled improperly
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux-GTK
: P3 trivial (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-06 16:51 EDT by CDE Administration CLA
Modified: 2007-09-18 04:45 EDT (History)
5 users (show)

See Also:
Szymon.Brandys: review+

Attachments
Patch fixes this bug (825 bytes, patch)
2007-08-31 08:35 EDT, Krzysztof Michalski CLA 		no flags Details | Diff
Patch fixes this bug (825 bytes, patch)
2007-09-04 10:24 EDT, Krzysztof Michalski CLA 		no flags Details | Diff
Patch is response for Simon comment (1.82 KB, patch)
2007-09-05 11:16 EDT, Krzysztof Michalski CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CDE Administration CLA 2007-06-06 16:51:24 EDT 
<response_by> Moravia IT at 2007.06.06.15.16.41 </response_by>
Subject: pl: functional: active Edit, Delete buttons
OS: Linux only
Build date: 20070605
Component name: Base Windows Menu
Blocking: no
Tester Name: Kamil Ignacak (PL)

Steps to recreate the problem:
- go to main menu -> Window -> Preferences
- select General -> Network Connections
- select Manual proxy configuration radio button

Problem description:
Buttons Edit and Delete are active when no item on the list is selected. They turn to inactive state only after adding new host and deleting it.

Kamil

<response_by> Bryan Green at 2007.06.06.15.45.43 </response_by>
Forwarding to Development...

<response_by> Bryan Green at 2007.06.06.15.46.06 </response_by>
This article was reassigned from Category:''TVT Testcases''.
Comment 1 CDE Administration CLA 2007-06-06 16:51:33 EDT 
<cde:tctdetail>
Testcase: 03.001062
Project: WSW33
Component: CDE - Platform/UI
Priority: 4
Subject: pl: functional: active Edit, Delete buttons
Article ID: 640
Originator: tctbroadcast@pl.moraviaworldwide.com
</cde:tctdetail>
Comment 2 Krzysztof Michalski CLA 2007-08-31 08:35:12 EDT 
Created attachment 77455 [details]
Patch fixes this bug
Comment 3 Krzysztof Michalski CLA 2007-08-31 08:36:25 EDT 
Bug should be reassigned to UI component.
Comment 4 Krzysztof Michalski CLA 2007-09-04 10:24:41 EDT 
Created attachment 77650 [details]
Patch fixes this bug
Comment 5 Michael Valenta CLA 2007-09-04 10:48:02 EDT 
The plug-in in question is owned by Team. Assigning back to Team
Comment 6 Szymon Brandys CLA 2007-09-05 09:55:31 EDT 
I would remove NonProxyHostsComposite#enableComposite(...) and move table_.setEnabled(enabled); to NonProxyHostsComposite#setEnabled(...).
In ProxyPreferencePage#enableControls(...) I would call nonHostComposite.enableComposite(enabled).
Comment 7 Krzysztof Michalski CLA 2007-09-05 11:16:22 EDT 
Created attachment 77733 [details]
Patch is response for Simon comment
Comment 8 Michael Valenta CLA 2007-09-07 11:18:33 EDT 
Patch released to HEAD
Comment 9 Szymon Brandys CLA 2007-09-18 04:45:44 EDT 
Verified in I20070917-1300.