Community
Participate
Working Groups
- Load version 0.044 [ne] 01 of ImageDescriptor and URLImageDescriptor, which add trace statements. - Repeatedly switch between two views (e.g. task list and properties). - You see two print statements on the console each time: createImage: URLImageDescriptor(eclipse:/plugin/com.ibm.jdt.ui/icons/full/ctool16/java_pers.gif) createImage: URLImageDescriptor(eclipse:/plugin/com.ibm.jdt.ui/icons/full/ctool16/java_pers.gif) This is the image for the Java perspectives. WorkbenchWindow.updateActionBars() does and updateAll() on the menu manager, which forces all menu items, even those not currently visible, to be updated, which causes SwitchToPerspMenu to fill the menu, which loads the images each time (it doesn't cache). Recommend: 1. WorkbenchWindow.updateActionBars() should do an update(false), not an updateAll(false). - Is there any downside to this? The menus should update themselves when shown. 2. SwitchToPerspMenu should cache its images (tricky given API on contribution items; see ActionContributionitem). NOTES: NE (04/12/01 6:39:18 PM) Released change 1 above as WorkbenchWindow 0.044 [ne] 01. NE (5/2/01 10:24:51 PM) Had to back out of this change because accelerators were not getting hooked properly with lazily created menus.
PRODUCT VERSION: 0.044
Can this defect be closed?
Need to reinvestigate as part of performance work. They should not be getting recreated given the way action contribution items cache images now, but it's still possible if the menus are managing their own images.
Code changes done.
