Bug 190674 - Conflicting resources message lost when typing in commit wizard
Summary: Conflicting resources message lost when typing in commit wizard
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-03 00:04 EDT by Brock Janiczak CLA
Modified: 2007-08-10 07:23 EDT (History)
1 user (show)

See Also:

Attachments
patch to org.eclipse.team.cvs.ui (2.21 KB, patch)
2007-06-03 00:05 EDT, Brock Janiczak CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2007-06-03 00:04:00 EDT 
Version: 3.3.0
Build id: I20070525-1350

When committing resources that have sync conflicts you are correctly shown an error about being unable to commit until they have been removed from the sync set.  However, typing into the commit area removes this error and enables the finish button on the wizard.  Committing will work for all files that are up to date, but give errors for those with sync conflicts.

Attached is a patch to keep the error visible and the finish button disabled until the resources have been excluded from the sync set.
Comment 1 Brock Janiczak CLA 2007-06-03 00:05:51 EDT 
Created attachment 69877 [details]
patch to org.eclipse.team.cvs.ui
Comment 2 Michael Valenta CLA 2007-06-04 09:48:06 EDT 
Thanks for the patch
Comment 3 Michael Valenta CLA 2007-06-21 14:06:44 EDT 
Patch released. Thanks.
Comment 4 Szymon Brandys CLA 2007-08-10 07:23:11 EDT 
Verified in build I20070808-1800