Bug 189934 - [WorkingSets] Break apart working set action set
Summary: [WorkingSets] Break apart working set action set
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.3 RC3   Edit
Assignee: Kim Horne CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2007-05-30 10:41 EDT by Kim Horne CLA
Modified: 2007-05-31 10:09 EDT (History)
2 users (show)

See Also:
eclipse: pmc_approved? (Mike_Wilson)

Attachments
Patch against org.eclipse.ui.ide (4.72 KB, patch)
2007-05-30 10:43 EDT, Kim Horne CLA 		eclipse: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2007-05-30 10:41:27 EDT 
From discussions in bug 180926 it was requested that I break apart the working set into two action sets - one that provides for the ability to change the window working set and the other to modify the contents of the sets themselves.  

I have such a patch available and would like to get it in for RC3 if possible.  If not, I wont lose sleep over it.
Comment 1 Kim Horne CLA 2007-05-30 10:43:27 EDT 
Created attachment 69293 [details]
Patch against org.eclipse.ui.ide

The gotcha for this one is that it causes a few new strings to be generated in the  plugin properties.
Comment 2 Martin Aeschlimann CLA 2007-05-30 12:28:12 EDT 
I think we better do this fix as it will bring back the 'Window Working Set' selection button and menus which otherwise would be hidden by default. Several views and dialog offer a Window Working Set filter.
Comment 3 Kim Horne CLA 2007-05-30 12:52:19 EDT 
This patch doesn't include the default=true flag for the window working set action set.  I didn't think breaking them apart would alleviate peoples annoyance with having 1 button instead of 0.
Comment 4 Mike Wilson CLA 2007-05-30 13:58:42 EDT 
+1 to the patch to split it into two actions sets
Comment 5 Kim Horne CLA 2007-05-30 14:06:31 EDT 
Fix in HEAD.
Comment 6 Kim Horne CLA 2007-05-31 10:09:23 EDT 
Verified in I20070531-0010