Bug 189810 - [Presentations] Floating toolbar from the synchronize view
Summary: [Presentations] Floating toolbar from the synchronize view
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-29 21:08 EDT by Olivier Thomann CLA
Modified: 2019-09-06 15:30 EDT (History)
5 users (show)

See Also:


Attachments
Screenshot (18.18 KB, image/png)
2007-05-29 21:08 EDT, Olivier Thomann CLA
no flags Details
Floating toolbar from view in stack (7.65 KB, image/gif)
2009-10-10 15:42 EDT, Donald Dunne CLA
no flags Details
The buggy version of the ATS perspective (2.92 KB, application/octet-stream)
2010-01-07 00:25 EST, Ryan Schmitt CLA
no flags Details
The new ATS perspective that works around the floating toolbar bug (3.08 KB, application/octet-stream)
2010-01-07 00:26 EST, Ryan Schmitt CLA
no flags Details
Floating toolbar in Eclipse's Debug perspective (69.04 KB, image/png)
2010-01-11 13:29 EST, Ryan Schmitt CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2007-05-29 21:08:08 EDT
I don't know if the problem comes from SWT or the synchronize view itself.
See the attached screenshot. I got a "floating" toolbar. The toolbar was no longer attached to the right view.
As soon as I resized the window, it was back to normal.
Comment 1 Olivier Thomann CLA 2007-05-29 21:08:32 EDT
Created attachment 69199 [details]
Screenshot
Comment 2 Michael Valenta CLA 2007-05-30 08:29:28 EDT
I know that Paul and/or Eric have investigated floating toolbar issues in the past.
Comment 3 Donald Dunne CLA 2009-10-10 15:42:18 EDT
Upon upgrade to 3.5, OSEE (www.eclipse.org/osee) applications started showing floating toolbars from different views (see screenshot).  The toolbar is actually from the second view in the stack.  Only work-around is resetting the perspective.

I have tried to debug this extensively and can't see anything the views are doing wrong.  The floating toolbar doesn't come from the same view everytime.  It all depends on which perspective is opened and which views are in the stack.

If kill process and restart, it comes back every time.  Resizing view manually or by double-click does nothing.  Only reset perspective and shutting down normally will cure the problem for a while.

See attachment
Comment 4 Donald Dunne CLA 2009-10-10 15:42:49 EDT
Created attachment 149310 [details]
Floating toolbar from view in stack
Comment 5 Eric Moffatt CLA 2009-10-13 15:25:13 EDT
Don, a few starter questions...;-)

Did you get this when switching away from the 'second' view to the one in the image? Had that TB been visible during this eclipse session?

Is there some repeatable set of steps I might use to reproduce this?

Do you know if the application is doing anything 'funky' such as modifying which views are active...during a perspective switch or other operation?

While we have had quite a number of issues with 'floating' TB's in the past but (for us) most of them have gone away in 3.5, I'm just trying to figure out what might be different in your environment.
Comment 6 Donald Dunne CLA 2009-10-13 17:44:11 EDT
>Did you get this when switching away from the 'second' view to the one in the
>image? Had that TB been visible during this eclipse session?

We started to encounter the problem when we migrated to 3.5 about a month ago.  Happens on startup (both released application and runtime) and does not get cleaned up by expanding view manually (dragging right edge) or full-screen-expanding by double-clicking view tab.  It does get cleaned up by selecting the view that "owns" the toolbar or by resetting the perspective.  Seems to go away for a while and then something causes it to come back.

>Is there some repeatable set of steps I might use to reproduce this?

I have not found a reliable way of repeating, however once it starts happening in a runtime, I can make it happen every time by killing the debug session without shutting down normally.  I have re-worked all the views in that quadrant (3-4) and even gutted the offending view until there was nothing but one contribution in the toolbar and no change. 

>Do you know if the application is doing anything 'funky' such as modifying
>which views are active...during a perspective switch or other operation?

These are standard views just loading the first time.  And what finally made me assume it was an eclipse bug is we started seeing it in different perspectives with different views contributing the floating toolbar.  They are our perspectives, but I couldn't find anything in the perspective definition that would cause it.

>While we have had quite a number of issues with 'floating' TB's in the past but
>(for us) most of them have gone away in 3.5, I'm just trying to figure out what
>might be different in your environment.

Is there anything that will refresh a toolbar after all views created besides  getViewSite().getActionBars().updateActionBars(); ?  It's weird that a reset perspective causes everything to re-calculate and draw correctly.
Comment 7 Ryan Schmitt CLA 2010-01-07 00:25:13 EST
Created attachment 155473 [details]
The buggy version of the ATS perspective
Comment 8 Ryan Schmitt CLA 2010-01-07 00:26:16 EST
Created attachment 155474 [details]
The new ATS perspective that works around the floating toolbar bug
Comment 9 Ryan Schmitt CLA 2010-01-07 01:02:43 EST
I was able to determine a procedure to reliably reproduce this bug in OSEE's ATS perspective:

1) Reset the ATS perspective
2) Open the Artifact Explorer view
3) Double-click a folder to open it in the Artifact Editor
4) Open the ATS Navigator
5) Click the artifact editor pane, so that it is active
6) Close and restart OSEE

I found it interesting that step (5) is crucial. Any artifact editors that are open upon shutdown will not be there after OSEE is restarted, and if (for instance) the ATS Navigator is the active view (instead of the artifact editor) the floating toolbar bug will not appear.

The workaround was to move the views into different folders, and limit the number of views in any one folder. Nonetheless, I've found that I can still occasionally reproduce the bug if too many views accumulate in the bottom folder. In such a case, the toolbar of the first toolbar-bearing view in the bottom folder will float in the usual location (which is shown in Don's screen shot).
Comment 10 Ryan Schmitt CLA 2010-01-11 13:29:25 EST
Created attachment 155777 [details]
Floating toolbar in Eclipse's Debug perspective

I just accidentally reproduced this bug in the Debug perspective. Here, the floating toolbar belongs to the History view (note the high density of tabs in that folder).

When I last shut down Eclipse, the active view was an OSEE Artifact Editor. As I mentioned in a previous comment, these editors are not restored after restarts.
Comment 11 Eric Moffatt CLA 2010-01-11 14:00:49 EST
Ryan, you shut down with the Artifact Editor active but it isn't restored on a subsequent restart, correct?

Thanks for this, it may give me a way to reproduce (and, ultimately, track down) this defect. I can set this scenario up fairly easily using Compare editors I think.
Comment 12 Ryan Schmitt CLA 2010-01-11 16:45:59 EST
(In reply to comment #11)
> Ryan, you shut down with the Artifact Editor active but it isn't restored on a
> subsequent restart, correct?

That's correct.
Comment 13 Eclipse Webmaster CLA 2019-09-06 15:30:12 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.