Bug 189476 - fix layout problems with the Mylyn UI Legend dialog
Summary: fix layout problems with the Mylyn UI Legend dialog
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P4 minor (vote)
Target Milestone: 3.0   Edit
Assignee: Leo Dos Santos CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-05-28 13:23 EDT by Eugene Kuleshov CLA
Modified: 2007-11-27 12:23 EST (History)
2 users (show)

See Also:


Attachments
current legend look (17.67 KB, image/gif)
2007-05-28 13:24 EDT, Eugene Kuleshov CLA
no flags Details
UI Legend layout improvements. (27.25 KB, patch)
2007-11-26 01:33 EST, Leo Dos Santos CLA
no flags Details | Diff
mylyn/context/zip (5.35 KB, application/octet-stream)
2007-11-26 01:33 EST, Leo Dos Santos CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2007-05-28 13:23:20 EDT
There are some weird layout issues with mylar ui legend.

Actually I wonder if that thing should be just section in Eclipse help system, so plugins would contribute to it and Help -> Mylar UI Legend action would just open that help section.
Comment 1 Eugene Kuleshov CLA 2007-05-28 13:24:42 EDT
Created attachment 68938 [details]
current legend look

I also find it weird that this popup is modeal and can't be moved around.
Comment 2 Willian Mitsuda CLA 2007-06-02 22:39:55 EDT
One thing that bugs me is that the current legend ui doesn't appear to be scalable.
Comment 3 Mik Kersten CLA 2007-06-05 22:54:05 EDT
Need to make at least minor improvements for 2.0.
Comment 4 Mik Kersten CLA 2007-06-27 03:27:33 EDT
Some fixes and improvements made for 2.0, can consider further improvements for 3.0.
Comment 5 David Carver CLA 2007-10-16 23:42:36 EDT
(In reply to comment #1)
> Created an attachment (id=68938) [details]
> current legend look
> 
> I also find it weird that this popup is modeal and can't be moved around.
> 

I've had users make this request as well.. Another thing to consider is making it a view that could be docked or detached if necessary.

Comment 6 Eugene Kuleshov CLA 2007-10-17 11:55:54 EDT
(In reply to comment #5)
> I've had users make this request as well.. Another thing to consider is making
> it a view that could be docked or detached if necessary.

I always wondered why it is not done trough the regular help. In that case it would be shown using dynamic help view.
Comment 7 Mik Kersten CLA 2007-10-26 01:17:33 EDT
As far as I know Dynamic Help does not support the dynamic rendering of SWT widgets, only the fixed display of markup content.  If that's not the case please let me know.  But someone could file a bug for us to better integrate it with dynamic help.

Dave: let us know if you're interested in contributing a patch.  It would also be helpful if you could attach a screenshot of the problem that you see, in case your case is that of an additional connector.
Comment 8 Eugene Kuleshov CLA 2007-10-26 02:01:17 EDT
 (In reply to comment #7)
> As far as I know Dynamic Help does not support the dynamic rendering of SWT
> widgets, only the fixed display of markup content.  If that's not the case
> please let me know.  But someone could file a bug for us to better integrate it
> with dynamic help.

It should be possible to render offscreen images and then assemble them with dynamic content using custom AbstractContentExtensionProvider and/or IHelpContentProducer. See extension points org.eclipse.help.contentExtension and org.eclipse.help.contentProducer.
Comment 9 David Carver CLA 2007-10-26 09:01:04 EDT
(In reply to comment #7)
> As far as I know Dynamic Help does not support the dynamic rendering of SWT
> widgets, only the fixed display of markup content.  If that's not the case
> please let me know.  But someone could file a bug for us to better integrate it
> with dynamic help.
> 
> Dave: let us know if you're interested in contributing a patch.  It would also
> be helpful if you could attach a screenshot of the problem that you see, in
> case your case is that of an additional connector.
> 

Might want to make this a bugday suggestion, since today is bugday.  If I get some time in the next few weeks I'll take a crack at it.
Comment 10 Mik Kersten CLA 2007-10-26 14:03:08 EDT
Dave: agreed.  Improving the layout of the current dialog is a nicely self-contained task.

Eugene: in terms of dynamically assembling images, in this way, consider submitting a new bug.  I'm not sure whether/when it will be worth the effort, although I do like the idea of making this legend more integrated and consistent, and we could always consider a contribution for it.
Comment 11 Leo Dos Santos CLA 2007-11-26 01:33:39 EST
Created attachment 83742 [details]
UI Legend layout improvements.

I thought I'd take a shot at improving the layout and header section of the dialog. This patch does nothing to improve the modality issue or some of the other things suggested, but it does make it prettier!
Comment 12 Leo Dos Santos CLA 2007-11-26 01:33:42 EST
Created attachment 83743 [details]
mylyn/context/zip
Comment 13 Mik Kersten CLA 2007-11-27 12:23:38 EST
Patch applied.  Nice work Leo!  This looks much better.  Additional improvements can go on separate bug reports.