Bug 189304 - [Sync Info] cvsignore lines should be split on whitespace
Summary: [Sync Info] cvsignore lines should be split on whitespace
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-26 23:46 EDT by Matt McCutchen CLA
Modified: 2007-08-08 07:42 EDT (History)
2 users (show)

See Also:

Attachments
Fix in SyncFileWriter#readCVSIgnoreEntries (1.44 KB, patch)
2007-05-26 23:48 EDT, Matt McCutchen CLA 		no flags Details | Diff
Fix in SyncFileWriter#readCVSIgnoreEntries without NPE (1.48 KB, patch)
2007-06-07 13:35 EDT, Matt McCutchen CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen CLA 2007-05-26 23:46:42 EDT 
Build ID: HEAD as of 5/26/2007

Eclipse should split cvsignore lines on spaces and tabs like the command-line CVS does.  A cvsignore file containing the single line "foo bar" causes the command-line CVS to ignore both "foo" and "bar" but currently causes Eclipse to ignore a file "foo bar" with a space in the name.  The GNU make repository is an example of a repository with .cvsignore files that have multiple whitespace-separated patterns on the same line.

Steps To Reproduce:
1. In Eclipse, check out module "make" from :pserver:anoncvs@cvs.savannah.gnu.org:/sources/make .
2. In the project, create a file called "Makefile".
3. Notice that the file is decorated "?" even though "Makefile" is listed on one of the lines of the .cvsignore at the root of the project.
Comment 1 Matt McCutchen CLA 2007-05-26 23:48:33 EDT 
Created attachment 68865 [details]
Fix in SyncFileWriter#readCVSIgnoreEntries
Comment 2 Michael Valenta CLA 2007-05-28 16:58:37 EDT 
Thanks for the patch. Unfortunately, we're locking down for 3.3 so this will have to wait until 3.4.
Comment 3 Matt McCutchen CLA 2007-05-28 17:31:52 EDT 
That's fine with me.
Comment 4 Matt McCutchen CLA 2007-06-07 13:35:00 EDT 
Created attachment 70536 [details]
Fix in SyncFileWriter#readCVSIgnoreEntries without NPE

My previous patch threw NullPointerException if .cvsignore did not exist.  This revised patch fixes the problem.
Comment 5 Michael Valenta CLA 2007-06-21 11:43:40 EDT 
Patch released to HEAD.
Comment 6 Tomasz Zarna CLA 2007-08-08 05:40:51 EDT 
Verified in I20070806-1800.
Comment 7 Tomasz Zarna CLA 2007-08-08 07:42:43 EDT 
I've opened bug 199239 for filenames containing spaces.