Bug 189054 - deadlock in ContextCorePlugin.start
Summary: deadlock in ContextCorePlugin.start
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-24 18:52 EDT by Michael Scharf CLA
Modified: 2007-06-21 20:52 EDT (History)
0 users

See Also:


Attachments
mylyn/context/zip (16.67 KB, application/octet-stream)
2007-06-21 16:41 EDT, Mik Kersten CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Scharf CLA 2007-05-24 18:52:54 EDT
org.eclipse.mylar.context.core.ContextCorePlugin.start can deadlock!
This seems to be a problem with sun java VMs. The problem comes from
the fact that ContextCorePlugin.start tries to create a executable extension. 

For details (including stack trace) see bug 188943. I filed this bug against equinox and they marked it as fixed:

> Actually there is a more general "best practice" that says "do as few as
> possible in the activator" and since creating an executable extension is not a
> trivial operation it falls under the typical things that you should not do.

I think this is a major bug, because the only way to get out of the deadlock is to kill eclipse. It happend to me several times at startup.

I use org.eclipse.mylar.ide_feature_2.0.0.v20070403 with eclipse 3.3 M7
Comment 1 Mik Kersten CLA 2007-05-27 23:19:11 EDT
Yes, we are trying to do as little as we can in the activator, but have additional requirements there that other plug-ins don't (e.g. see comment#10 on bug 187202).  That' said, we haven't had a deadlock reported for months, since we made these improvements, so I need to figure out what could have caused it.  Thanks for the pointer to the thread dump.
Comment 2 Mik Kersten CLA 2007-05-27 23:19:36 EDT
Btw, does this happen every time, frequently, or intermittently?
Comment 3 Michael Scharf CLA 2007-05-30 22:18:51 EDT
I upgraded to mylar 2.0.0.v20070514 and it still happened. I was not able to start one of my workspaces without deadlock. Then I decided to uninstall mylar, which made me really suffer, because it's hard to work without mylar. After 2 days of suffering without mylar, I reinstalled it and the problem is gone.

It is very strange that it happened 5-6 times in a row and I had to kill eclipse every time and I could not get into my workspace. Now it has not happened for 2 days or so.
Comment 4 Mik Kersten CLA 2007-06-21 16:41:06 EDT
The context store is now extension point based and we should longer do any extension point reading on start(..).
Comment 5 Mik Kersten CLA 2007-06-21 16:41:11 EDT
Created attachment 72089 [details]
mylyn/context/zip
Comment 6 Michael Scharf CLA 2007-06-21 20:52:13 EDT
cool :-)