Bug 189034 - [Viewers] Collapse all in debug views gets rid of plus signs
Summary: [Viewers] Collapse all in debug views gets rid of plus signs
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: 3.3.1 deferred
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-24 17:16 EDT by Boris Bokowski CLA
Modified: 2019-09-06 16:05 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2007-05-24 17:16:21 EDT
I20070524-0010

Using the example program below, use the following steps:
1. Add breakpoint at System.out line
2. Debug
3. Resize Variables view to show about ten lines
4. Arrow down/right/down into the array to about index 15
5. Press the "Collapse All" toolbar button
6. Expand "a" again
Expected: plus signs next to the elements of a
Actual: No plus signs next to those elements that had been materialized before

Happens on the Mac and on Windows.

package snip;

import java.util.Date;

public class J {

	public static void main(String[] args) {
		Object[] a = new Object[20];
		for (int i = 0; i < a.length; i++) {
			a[i] = new Date();
		}
		System.out.println("breakpoint here");
	}
}
Comment 1 Boris Bokowski CLA 2007-05-24 17:26:54 EDT
Cannot reproduce using a modified version of the snippet from bug 188663 (added a collapseAll button and added a couple more child and grandchild nodes), so my current guess is that this is specific to Debug.
Comment 2 Darin Wright CLA 2007-05-31 13:02:36 EDT
I only see the problem in my host, but not my target.
Comment 3 Darin Wright CLA 2007-05-31 13:53:32 EDT
Ahha - seems to be linked to filter settings which differred in my host/target. The problem only happens if I don't show statics or constants.
Comment 4 Darin Wright CLA 2007-05-31 14:09:23 EDT
I think this is a JFace bug. When the tree is recursively collapsing children, it gets to array entry items, which have dummy children (1 child with null 'data'), since they have never been expanded. The call to #getChildren(widget) for the array entry element returns the dummy element, but has the side effect of causing a #setData callback. This populates the item asynchronously, but in our case the first model object is filtered, so it is removed. This removes the dummy item from the tree, making the plus sign disappear. So, a child is retrieved, but the child count was never updated properly. For the case of a virtual tree, I think the child count should be updated in the case that a dummy child is found/collapsed.
Comment 5 Boris Bokowski CLA 2007-06-02 09:49:58 EDT
Marking 3.3.1 - I doubt that I will be able to provide a fix that is safe enough for 3.3. Darin, do you agree?
Comment 6 Darin Wright CLA 2007-06-03 23:14:42 EDT
I'm not sure how tricky the fix is... but 3.3.1 is fine with me.
Comment 7 Kim Horne CLA 2007-08-31 09:41:44 EDT
Removing the 3.3.1 target
Comment 8 Boris Bokowski CLA 2009-11-26 09:46:57 EST
Hitesh is now responsible for watching bugs in the [Viewers] component area.
Comment 9 Eclipse Webmaster CLA 2019-09-06 16:05:47 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.