Bug 188883 - [Actions] Compare with Each Other action caches compare input
Summary: [Actions] Compare with Each Other action caches compare input
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 188364
  Show dependency tree
 
Reported: 2007-05-24 07:32 EDT by Martin Oberhuber CLA
Modified: 2019-09-06 16:17 EDT (History)
1 user (show)

See Also:


Attachments
Test project with 3 files to compare (762 bytes, application/force-download)
2007-05-24 07:33 EDT, Martin Oberhuber CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-05-24 07:32:05 EDT
+++ This bug was initially created as a clone of Bug #188364 +++
eclipse-SDK-3.3RC1 on windows or linux-gtk-x86_64 

Switch on Preferences : General : Compare : Ignore Whitespace, press OK
Compare two text files --> Whitespace is not ignored
Quit and re-start Eclipse --> Whitespace is ignored
Comment 1 Martin Oberhuber CLA 2007-05-24 07:33:46 EDT
Created attachment 68544 [details]
Test project with 3 files to compare

Attached ZIP contains 3 test files that should compare equal when "ignore whitespace" is switched on.

Choose File > Import > Existing Projects > Archive File to import.
Comment 2 Martin Oberhuber CLA 2007-05-24 07:35:30 EDT
I think that the Preference used to be applied immediately in previous versions of Eclipse, so this may be a regression.
Comment 3 Michael Valenta CLA 2007-05-24 11:56:16 EDT
I have been able to reproduce this intermittently but a restart is not required to fix the problem (i.e. when I saw the problem, closing the editor and performing the compare again yielded the expected result). It appears there is a delay between when the preference is set in the dialog and when the preference is picked up by Compare with Each Other.
Comment 4 Michael Valenta CLA 2007-05-24 12:58:20 EDT
I've tracked this down. It is specific to the Compare With Each Other action. Here are the steps to reproduce.

1) Select two files and right-click to open the context menu but do not run the Compare With Each Other action.

2) Change the Ignore Whitespace preference

3) Execute the Compare with Each Other action

In step 1) the compare configuration gets cached in the action. Running the action clears the cache. 

This is not a regression since this code has not been touched in 3.3. We plan on addressing Compare with Each Other issues in 3.4 since we didn't have time in 3.3.
Comment 5 Szymon Brandys CLA 2008-05-09 04:23:31 EDT
Mass update - removing 3.4 target. This was one of the bugs marked for
investigation (and potential fixing) in 3.4 but we ran out of time. Please ping
on the bug if fixing it would be really important for 3.4, and does not require
API changes or feature work.
Comment 6 Eclipse Webmaster CLA 2019-09-06 16:17:05 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.