Bug 188827 - [Dialogs] Open Resource dialog should not show non-resource working sets
Summary: [Dialogs] Open Resource dialog should not show non-resource working sets
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 193047
Blocks:
  Show dependency tree
 
Reported: 2007-05-24 02:56 EDT by Eugene Kuleshov CLA
Modified: 2019-09-06 15:34 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2007-05-24 02:56:13 EDT
This is related to Europa release.

Mylar project recently introduced Task working sets that operate on something that has nothing to do with resources. However, those task working sets appear in the "Open Resource" dialog drop down and when Window working set is only including task working set "Open Resource" dialog don't show any hits at all.

Also, even if I pick "No working set" option in the "Open Resource" dialog it still show no hits, like it is actually using "Window working set".

So, I believe there is a bug in the filtering code that deal with working sets in the "Open Resource" dialog.

Also, it would make sense to filter out non-resource working sets from the "Open Resource" dialog UI, since those won't do any good there.
Comment 1 Eugene Kuleshov CLA 2007-06-06 17:17:09 EDT
Is there are chance that this issue will be addressed for 3.3 release (Europa)?

Also note that the same issue can be reproduced using Breakpont working sets contributed by Platform/Debug (or JDT). So, Open Resource dialog finds nothing if Window working set has Breakpont working set selected.
Comment 2 Mik Kersten CLA 2007-06-16 23:35:54 EDT
This problem in the description turned out to be that the Mylyn TaskWorkingSetPage.performFinish() was adding all adaptables instead those matching AbstractTaskContainer (bug 189308).  This was effectively making the task working sets function like resource working sets that contained no resources.  So if a particular facility (e.g. Open Resource, Package Explorer) had no other resource working sets selected it would not show any resources.
Comment 3 Mik Kersten CLA 2007-06-17 21:51:59 EDT
I made a mistake in the diagnosis described in comment#2.  I had nothing in the Breakpoint working set that I was testing this with, and the Open Resource dialog's working set filtering mechanism has a special case that if the only working set is empty it will set the working set to filter on to be null instead of the Window Working Set. 

I created bug 193047 to desribe the root problem and steps to reproduce.  Reopening this bug open because it might make sense to make a fix or work-around for the Open.
Comment 4 Szymon Brandys CLA 2008-05-30 11:28:10 EDT
Reassigning to Susan.
Comment 5 Susan McCourt CLA 2009-07-09 17:19:41 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 6 Eclipse Webmaster CLA 2019-09-06 15:34:54 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.