Bug 188650 - [clean up][format] need to catch up from bug 185928
Summary: [clean up][format] need to catch up from bug 185928
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC2   Edit
Assignee: Benno Baumgartner CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 185928
Blocks:
  Show dependency tree
 
Reported: 2007-05-23 10:29 EDT by Benno Baumgartner CLA
Modified: 2007-05-26 05:40 EDT (History)
2 users (show)

See Also:
martinae: review+
daniel_megert: review+

Attachments
fix (5.22 KB, patch)
2007-05-23 10:31 EDT, Benno Baumgartner CLA 		no flags Details | Diff
fix (5.52 KB, patch)
2007-05-25 10:01 EDT, Benno Baumgartner CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2007-05-23 10:29:49 EDT 
I20070523-0010

Clean up and format action should use the new option described in bug 185928
Comment 1 Benno Baumgartner CLA 2007-05-23 10:31:59 EDT 
Created attachment 68343 [details]
fix
Comment 2 Martin Aeschlimann CLA 2007-05-23 11:59:35 EDT 
patch is good
Comment 3 Martin Aeschlimann CLA 2007-05-23 12:00:08 EDT 
maybe one minor improvement: call the method 'reformat'. 'reFormat' looks strange.
Comment 4 Benno Baumgartner CLA 2007-05-24 04:45:43 EDT 
(In reply to comment #3)
> maybe one minor improvement: call the method 'reformat'. 'reFormat' looks
> strange.
> 

Yes, will do, reformat is only one word of course.
Comment 5 Dani Megert CLA 2007-05-24 06:18:44 EDT 
Fix is good but for 3.4 we should cleanup the formatter stuff:
- CodeFormatterUtil is internal and hence we should clean it up so that there's
  only reformat and format.
- all code that formats should go through the CodeFormatterUtil and not go
  directly to JDT Core (like the comment formatter currently does).

I filed bug 188864 for that.
Comment 6 Benno Baumgartner CLA 2007-05-24 08:21:54 EDT 
fixed > I20070524-0010
Comment 7 Benno Baumgartner CLA 2007-05-25 09:49:37 EDT 
Need to adopt to new constant name
Comment 8 Benno Baumgartner CLA 2007-05-25 10:01:49 EDT 
Created attachment 68769 [details]
fix
Comment 9 Martin Aeschlimann CLA 2007-05-25 10:02:35 EDT 
patch is good, please release
Comment 10 Benno Baumgartner CLA 2007-05-25 10:03:47 EDT 
fixed > I20070525-0010
Comment 11 Dani Megert CLA 2007-05-26 05:40:01 EDT 
Verified in I20070525-1350.

Verified with and without the *NEVER* options. Verified that formatting of auto generated bodies is not broken in both cases.