Bug 188864 - Cleanup CodeFormatterUtil
Summary: Cleanup CodeFormatterUtil
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Benno Baumgartner CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-24 06:18 EDT by Dani Megert CLA
Modified: 2007-07-11 11:46 EDT (History)
0 users

See Also:

Attachments
clean up code (55.00 KB, patch)
2007-07-11 08:45 EDT, Benno Baumgartner CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-05-24 06:18:04 EDT 
3.3 RC1.

CodeFormatterUtil is internal and hence we should clean it up so that there's
only reformat and format.

We should ensure that all our code that formats goes through the CodeFormatterUtil and not go directly to JDT Core (like e.g. the comment formatter currently does).
Comment 1 Benno Baumgartner CLA 2007-05-24 07:48:21 EDT 
Also the code formatter action should use the clean up, this way we'll get an undo. Martin, I can take this bug if you want too...
Comment 2 Benno Baumgartner CLA 2007-07-11 08:45:44 EDT 
Created attachment 73528 [details]
clean up code
Comment 3 Benno Baumgartner CLA 2007-07-11 11:46:22 EDT 
Fixed > N20070707-0010

Filed bug 196179 for formatter undo