Community
Participate
Working Groups
Tried using Firefox and Safari. Get the following error message on Firefox: Unable to connect Firefox can't establish a connection to the server at localhost:8888 Plain "localhost" will open up a VNC login page (assuming default port 80) - do not know if this is interfering with the infocenter. I'm confident the infocenter server was actually started okay through the commandline because I am able to shut it down fine using the commandline.
I think that the instructions in the test may be incorrect, the test asks you to open http://localhost:8888/help - I found that I had to enter http://localhost:8888/help/index.jsp . Can you see if theis works and if so I'll update the test description.
Unfortunately, http://localhost:8888/help/index.jsp did not work for me either. I got the same error message
This is not Mac OS specific. I've reproduced on Linux and Windows. The problem is that the "-port <port #>" command is being ignored. If you open the ".metadata\.connection" file in the infocenter workspace ("d:\eclipse\infocenter\.metadata\.connection" for the command listed in the test plan) it has a line indicating the port that is in use ("port=<port #>"). This appears to be a random port assigned as usual and does not match the port supplied on the command line.
This is a regression which happened last week. The reason I didn't detect it is that I ran the infocenter tests on the build from May 15th, the same day that it was introduced. It appears that the regression was caused by the patch submitted by Simon Kaegi attached to Bug 184537. Using I20070515-0800 I observed the following. I20070515-0800 - Webapp works I20070515-0800 + org.eclipse.help.base - Webapp fails I20070515-0800 + org.eclipse.help.base v20070426 - Webapp works I20070515-0800 + org.eclipse.help.base v20070426 + proposed patch from Bug 184537 - Webapp fails I20070515-0800 + org.eclipse.help.base v20070426 + patch [1] from Bug 184537 - Webapp works I20070515-0800 + org.eclipse.help.base v20070426 + patch [2] from Bug 184537 - Webapp works I20070515-0800 + org.eclipse.help.base v20070426 + patch [3] from Bug 184537 - Webapp works Adam, can you figure out what it is about this patch that caused the Webapp to fail and see if you can fix it?
Created attachment 68396 [details] Patch The problem was caused the the option server_port being renamed to org.eclipse.help.server_port. The lowest risk path to fixing this is to set the name back to what it used to be which is what I have done.
Requesting review for RC2
The patch does not seem to work on Windows. A random port number is still being assigned. There must be another change that needs to be made.
Created attachment 68425 [details] reverted patch changes further Before the patch we were using: System.getProperty("server_port"); as opposed to: HelpBasePlugin.getBundleContext().getProperty("server_port"); The "-port" argument results in "-Dserver_port" getting set on the call to launch eclipse. Thus, the port is supplied as a jvm argument and must be retreived using System.getProperty("server_port"). I'm about to test to confirm.
Created attachment 68426 [details] same as previous There was a sloppy mistake in the last one. Sorry.
Comment on attachment 68426 [details] same as previous Unfortunately, this patch did not work for me (same error) on Mac. Essentially what I'm doing is checking out the latest org.eclipse.help.base source from HEAD, applying the patch to it , and then exporting that plugin back into the eclipse plugins directory. From there I successfully start the standalone infocenter server through the commandline
False alarm. Chris' patch is good. It seems that even if your classpath is pointed explicitly at the modified org.eclipse.help.base.*.jar you will run into problems (on Windows) if you have other copies of the jar in the plugins directory for the specified eclipsehome. To test the patch you not only need to export the new jar to your plugins directory and point to it with your command line argument, but you also need to remove other copies of the jar from the plugins directory.
Comment on attachment 68396 [details] Patch Works well on Mac. http://localhost:8888/help/index.jsp worked for me. Have to specify 'index.jsp' otherwise you get a proxy error. Adam was bang on regarding the need to remove the old version of the plug-in. As soon as I did that it worked.
Fixed for 3.3 RC2
Verified in I20070608-1718.
