Bug 188056 - [Preferences] PreferencePage s have to less indent in PreferenceDialog
Summary: [Preferences] PreferencePage s have to less indent in PreferenceDialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC2   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2007-05-21 06:07 EDT by Teddy Walker CLA
Modified: 2007-05-31 13:07 EDT (History)
2 users (show)

See Also:
eclipse: review+
pwebster: review+

Attachments
One line patch (826 bytes, patch)
2007-05-23 10:15 EDT, Stephan Wahlbrink CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Teddy Walker CLA 2007-05-21 06:07:45 EDT 
The pages content area are too tight to the separator between pages and treeview. They should be indented in one line with the title.

It's unaesthetic, but a usability issue too.
In 3.2 this space was correct.
Comment 1 Stephan Wahlbrink CLA 2007-05-23 10:15:16 EDT 
Created attachment 68338 [details]
One line patch

Originally, the indent was set in #createDialogArea(), line 442. But this was applied to the inner page composite, which is in 3.3 inside the ScrolledComposite, where the layout data has no effect.
Changes are kept to a minimum, the patch simply restores the 3.2 layout.
Comment 2 Tod Creasey CLA 2007-05-23 10:23:20 EDT 
Thanks Teddy
Comment 3 Tod Creasey CLA 2007-05-23 15:58:29 EDT 
Patch released for build 20070524-0100
Comment 4 Tod Creasey CLA 2007-05-25 09:12:53 EDT 
Verified the fix but I forgot the attribution for Teddy. I have updated this and added it for build >20070525
Comment 5 Tod Creasey CLA 2007-05-31 13:07:19 EDT 
Verified in I20070531-0010