Bug 188051 - [KeyBindings] [api] Additional API to query IBindingService with given active contexts
Summary: [KeyBindings] [api] Additional API to query IBindingService with given active...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 153895
Blocks:
  Show dependency tree
 
Reported: 2007-05-21 05:29 EDT by Dani Megert CLA
Modified: 2019-09-06 16:04 EDT (History)
2 users (show)

See Also:

Attachments
Initial Patch (16.13 KB, patch)
2008-02-08 15:36 EST, Jason Brennan CLA 		no flags Details | Diff
revised patch with passing test (16.17 KB, patch)
2008-02-11 12:28 EST, Jason Brennan CLA 		no flags Details | Diff
revised patch with passing test (12.04 KB, patch)
2008-02-11 12:54 EST, Jason Brennan CLA 		no flags Details | Diff
patch with test v03 (10.54 KB, patch)
2008-02-11 13:03 EST, Paul Webster CLA 		no flags Details | Diff
patch with test v04 (15.42 KB, patch)
2008-02-11 16:37 EST, Jason Brennan CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-05-21 05:29:50 EDT 
Please add
- IBindingService.getActiveBindingFor(commandId, activeContextIds)
- IBindingService.getActiveBindingFor(parameterizedCommand, activeContextIds)
- IBindingService.getBestActiveBindingFor(commandId, activeContextIds)
- IBindingService.getBestActiveBindingFor(parameterizedCommand,activeContextIds)

See bug 187306 and bug 187812 for details.
Comment 1 Markus Keller CLA 2007-05-23 04:52:12 EDT 
The first two methods should be called getActiveBindingsFor(..) ("Binding*s*").
Comment 2 Dani Megert CLA 2007-05-23 04:54:31 EDT 
of course ;-)
Comment 3 Jason Brennan CLA 2008-02-08 15:36:54 EST 
Created attachment 89305 [details]
Initial Patch
Comment 4 Jason Brennan CLA 2008-02-11 12:28:00 EST 
Created attachment 89429 [details]
revised patch with passing test
Comment 5 Jason Brennan CLA 2008-02-11 12:54:21 EST 
Created attachment 89433 [details]
revised patch with passing test
Comment 6 Paul Webster CLA 2008-02-11 13:03:46 EST 
Created attachment 89434 [details]
patch with test v03

Same patch with some of the formatting changes removed.

PW
Comment 7 Paul Webster CLA 2008-02-11 13:14:40 EST 
Jason, please rework the new BindingManager method to be:

getActiveBindingsForContexts(ParameterizedCommand command, Set localContexts)

Then add the equivalent method for localized contexts:

getBestActiveBindingForContext(ParameterizedCommand command, Set localContexts)

You should add another BindingManagerTest that adds at least 2 bindings for one parameterized command so that they can be sorted by the new method.  Check out one of the earlier tests we added.

Then we need to add those 2 methods to IBindingService and BindingService as passthrough methods.

PW
Comment 8 Jason Brennan CLA 2008-02-11 16:37:07 EST 
Created attachment 89453 [details]
patch with test v04
Comment 9 Paul Webster CLA 2009-03-02 11:41:03 EST 
Updated as per http://wiki.eclipse.org/Platform_UI/Bug_Triage
PW
Comment 10 Eclipse Webmaster CLA 2019-09-06 16:04:12 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.