Community
Participate
Working Groups
Build 20020602 (F2) When in an editor, the edit menu has "Quick Fix", accelerator key is Ctrl+1. When you select an error in the task list, the "Quick Fix" menu item in the edit menu is disabled, but the context menu contains "Autofix..." with no accelerator key. This should have the same name in both edit menu and task list context menu, and ideally it would have the same accelerator key.
Kai, how would you like to resolve this?
I'd like to propose the following: The workbench defines an action id for the Quick Fix action. The Compilation Unit Editor contributes a RetargetAction to the Edit menu. The editor and the task list provide handlers for the Quick Fix action id. As Quick Fix has become rather prominent in JDT by now, the name of the action is a sensitive issue. Therefore, the action should be Quick Fix rather then Auto Fix. For consistency, the task list action should be named Quick Fix as well.
So to summarize, the changes would be: - define a new global action id at workbench level for Quick Fix - by default there is no top level menu item for this - the CU editor contributes a retargetable Quick Fix item in the Edit menu, having this id - the Tasks view hooks its current implementation of Autofix as the handler for this - we rename the action on the Tasks view's context menu to Quick Fix If we do it this way, will the current Autofix implementation in the Tasks view match the behaviour of Quick Fix in the editor? How are open editors handled? Or will it just work the same because JDT contributes the resolutions and they properly handle open editors? Marking as a candidate for F3.
For the initial workbench activity, i.e. defining the id.
We have renamed Autofix to Quick Fix in the Tasks view and the related dialogs.
Will not add the Quick Fix retargetable action id for 2.0. Handling this in the Tasks view would require the Quick Fix action to update its enablement properly on every selection change. This may be costly since it needs to consult the marker help registry, and this is currently O(N) in the number of contributions. Should also rethink how to handle this case better, since simply adding a global action id for an action that's not contributed by the workbench, nor handled by the workbench proper, results in strange dependencies.
Reopened for investigation
*** Bug 68751 has been marked as a duplicate of this bug. ***
QuickFix underwent a rework in 3.2.
