Bug 187580 - Protect against JarProcessor exceptions
Summary: Protect against JarProcessor exceptions
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Platform-Update-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-17 11:51 EDT by Andrew Niefer CLA
Modified: 2007-06-06 11:43 EDT (History)
0 users

See Also:
dejan: review+

Attachments
patch (1.03 KB, patch)
2007-05-17 11:54 EDT, Andrew Niefer CLA 		no flags Details | Diff
updated patch (2.42 KB, patch)
2007-05-17 12:01 EDT, Andrew Niefer CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2007-05-17 11:51:50 EDT 
If there is some problem unpacking a pack.gz file during update, the JarProcessor may throw an exception.

Update should catch these exceptions and download the normal jar instead.

See bug 187396 where the downloaded pack.gz file was 0 bytes.
See also bug 185774 where ZipOutputStream threw a java.lang.InternalError
Comment 1 Andrew Niefer CLA 2007-05-17 11:54:23 EDT 
Created attachment 67669 [details]
patch

The attach patch catches throwable around jarprocessor.processJar.  In this case, we fall back to downloading the normal jar.
Comment 2 Andrew Niefer CLA 2007-05-17 11:55:17 EDT 
Dejan, what do you think about this.
Comment 3 Andrew Niefer CLA 2007-05-17 12:01:50 EDT 
Created attachment 67672 [details]
updated patch

This updated patch adds the same error handling around the fallback asLocalReference calls as there is around the call when there is no pack200 support to start with.
Comment 4 Andrew Niefer CLA 2007-05-17 12:36:06 EDT 
done in HEAD