Community
Participate
Working Groups
Since multiple cc's can be added at a single time by comma separating them, it would be nice to be able to use content assist to add more than 1 user to this list.
Frank, you've been doing excellent work on content assist of late. Would you consider taking this on as well?
(In reply to comment #1) > Frank, you've been doing excellent work on content assist of late. Would you > consider taking this on as well? OK, I try to do this.
Created attachment 92375 [details] Patch I also include some jUnit tests
Created attachment 92376 [details] mylyn/context/zip
Thanks Frank. If I try to enter multiple email addresses using content assist only the last entered email address is kept. Could you look into that and add a test case for it? Also it would be nice if the completion worked when there is a space after the comma or if only space is used as a separator, e.g. "email1, ema..." or "email1 email2".
(In reply to comment #5) > Thanks Frank. If I try to enter multiple email addresses using content assist > only the last entered email address is kept. Could you look into that and add a > test case for it? Steffen, only the one address where the cursor is located is used. Sorry I was under the impression that you enter the first address and use the content assist before you want the content assist for an other address. Actually I can not look at the code (I'am at work) if what you want is possible to implement. Will do this when I'am at home. > > Also it would be nice if the completion worked when there is a space after the > comma or if only space is used as a separator, e.g. "email1, ema..." or "email1 > email2". I test if space is a valid list separator. If so, I will implement this.
What I tried is that I entered "email1,ema" and then used content assist. The result was that only email2 remained in the text field and email1 was gone.
Created attachment 92521 [details] updated Patch Now it is possible to use comma and space as separator. The Error from Comment#7 is also fixed.
Created attachment 92522 [details] mylyn/context/zip
(In reply to comment #5) > Thanks Frank. If I try to enter multiple email addresses using content assist > only the last entered email address is kept. Could you look into that and add a > test case for it? Maybe we could try to overwrite ContentProposalPopup.createDialogArea() to start a new content assist if we find one more in the content. Thoughts?
Created attachment 92524 [details] mylyn/context/zip
Created attachment 93935 [details] updated patch
Created attachment 93936 [details] mylyn/context/zip
Thanks Frank! I have committed the updated patch which is based on your implementation. Please take a look if the changes I made address comment 10.
Created attachment 94077 [details] follow
Created attachment 94078 [details] followup patch (In reply to comment #14) > Thanks Frank! I have committed the updated patch which is based on your > implementation. Please take a look if the changes I made address comment 10. > Correction for jUnit Test (no longer fail). I now think that we only support one ContentProposalPopup. So If you type "f,b" you have to do this in two steps. Frist change to "foo, b" and then to "foo, bar"
Created attachment 94079 [details] mylyn/context/zip
Good catch. Patch applied an IP log updated. > I now think that we only support one ContentProposalPopup. So If you type "f,b" > you have to do this in two steps. > > Frist change to "foo, b" and then to "foo, bar" From the little bit of usage I have gathered on this feature so far it has been working well and only requires a few keystrokes. I think it is the least confusing user interaction that still makes it very easy to add multiple addresses.
(In reply to comment #18) > > From the little bit of usage I have gathered on this feature so far it has been > working well and only requires a few keystrokes. I think it is the least > confusing user interaction that still makes it very easy to add multiple > addresses. If we want to do this , I need some help. 1) What i the right place to inert the logic for generate the extra keystroke 2) How do I generet the extra keystroke.
Created attachment 94124 [details] Enhancement (In reply to comment #18) > > From the little bit of usage I have gathered on this feature so far it has been > working well and only requires a few keystrokes. I think it is the least > confusing user interaction that still makes it very easy to add multiple > addresses. What is with htis implementation? Starting with the current Cursorposition we do the content assist until we reach the left side.
Created attachment 94125 [details] mylyn/context/zip
Created attachment 94126 [details] update Sorry I did not remove the IContentProposalListener2 from the patch.
Created attachment 94127 [details] mylyn/context/zip
I don't quite understand how the patch improves content assist for multiple addresses. As I pointed out in comment 18 I think the current solution is sufficient.
(In reply to comment #24) > I don't quite understand how the patch improves content assist for multiple > addresses. As I pointed out in comment 18 I think the current solution is > sufficient. I stood under the impression that this extension was requested. Try this: 1) open Bug http://mylyn.eclipse.org/bugs303/show_bug.cgi?id=1 2) insert test, rob (Insert point is after rob) and use content assist, you get two proposals and end with tests@mylyn.eclipse.org,rob.elves@eclipse.org but if you place the Insert point is after test you get one proposals and end with tests@mylyn.eclipse.org,rob If you think that this is not needed it is no problem to not apply this patch. But maybe we should yue the move of the insert point to the new position. Thoughts?
Awesome to finally have this, thanks Frank!
