Bug 18647 - [CVS UI] Committing an unchanged file doesn't update decorator
Summary: [CVS UI] Committing an unchanged file doesn't update decorator
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M2   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: readme
: 8623 24061 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-06-01 22:44 EDT by Susan Franklin CLA
Modified: 2002-09-26 13:08 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan Franklin CLA 2002-06-01 22:44:24 EDT 
Running the F2 candidate (0601).
Connected to dev.eclipse.org CVS repository.
Working in Resources perspective.

1.  Open a file registered with an external editor (I was editing HTML)
2.  Edit the file, but then correct your edit so that there is no actual change.
3.  Save the file.
4.  Refresh the resource (you'll see the decorator indicating out of sync with 
repository.)
5.  Commit the change.
6.  The commit appears to be successful, but the decorator showing that the 
file is out of sync is still showing.

I did not try a scenario using an internal editor.  I suspect the same thing 
would happen.  

It seems that if there is no actual change to the contents of the file, CVS 
doesn't commit.  But the decorator indicates that the files are out of sync, so 
it's not using the same rules the server does.  The UI should either tell me 
that it didn't commit or update the decorator.

This bug sounds minor, but when you are doing a bunch of edits and committing 
at once, it's not so obvious why one file seemingly did not commit.  It took me 
awhile to figure out that this was a file that didn't actually change.
Comment 1 Kevin McGuire CLA 2002-06-02 12:24:13 EDT 
I agree its more of a problem than it looks on the surface - you can't tell 
when you are 'done'.

Suspect because there are no changes wrt the server the base timestamp isn't 
being updated, which is correct in a sense because the server one hasn't 
changed.

Should fix for F3
Comment 2 Michael Valenta CLA 2002-06-03 08:56:10 EDT 
This is only an issue for the Team/Commit action. If you commit from the sync 
view, This condition is detected and handled. The idea was to have Team/Update 
and Team/Commit work like the corresponding command line commands (in which 
case, you would do a Commit in conjuntion with an Update to commit your work 
and get any work anybody else did).
Comment 3 Kevin McGuire CLA 2002-06-09 18:04:48 EDT 
See also 15515 (already closed for other reasons).

I can't see any alternative for 2.0
Comment 4 Michael Valenta CLA 2002-09-08 21:23:47 EDT 
Reopening
Comment 5 Michael Valenta CLA 2002-09-25 10:09:52 EDT 
*** Bug 24061 has been marked as a duplicate of this bug. ***
Comment 6 Michael Valenta CLA 2002-09-25 20:12:42 EDT 
*** Bug 8623 has been marked as a duplicate of this bug. ***
Comment 7 Michael Valenta CLA 2002-09-26 13:08:51 EDT 
Fix released to HEAD.

Notification of timestamp reet is output to the CVS console.