Bug 186403 - [KeyBindings] provide conflict information to users outside of logging
Summary: [KeyBindings] provide conflict information to users outside of logging
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2007-05-10 12:07 EDT by Paul Webster CLA
Modified: 2007-05-22 13:48 EDT (History)
3 users (show)

See Also:


Attachments
Key Assist conflicts v03 (15.40 KB, patch)
2007-05-10 12:16 EDT, Paul Webster CLA
no flags Details | Diff
Key Assist conflicts v04 (16.71 KB, patch)
2007-05-10 12:40 EDT, Paul Webster CLA
no flags Details | Diff
Dialog (158.94 KB, image/png)
2007-05-15 10:53 EDT, Kim Horne CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2007-05-10 12:07:23 EDT
Exploring different logging scenarios in bug 185523 the log is not appropriate way of telling the user about a keybinding conflict

A better user feedback mechanism would be to open the Key Assist Dialog with the conflicting commands and allow the user to select one.

The logging is still necessary for capturing the runtime conflicts, but the user wouldn't be directed there.

PW
Comment 1 Paul Webster CLA 2007-05-10 12:16:58 EDT
Created attachment 66709 [details]
Key Assist conflicts v03

If the user tries to use a conflicted key :-) use the key assist dialog to allow them to choose from the available commands.

PW
Comment 2 Paul Webster CLA 2007-05-10 12:40:45 EDT
Created attachment 66715 [details]
Key Assist conflicts v04

When the user chooses a key combination that has a conflict, open the key assist dialog (the same one you get for ALT+SHIFT+Q) and let them choose between the commands that have the conflict.

PW
Comment 3 Kim Horne CLA 2007-05-15 10:52:01 EDT
The shell is kind of ugly but it works - +1.  Maybe the column widths can be adjusted to better use the space?  Screencap coming.
Comment 4 Kim Horne CLA 2007-05-15 10:53:14 EDT
Created attachment 67250 [details]
Dialog
Comment 5 Paul Webster CLA 2007-05-15 11:40:47 EDT
Released to HEAD >20070515 11:45

PW

There's code in the key assist dialog that's supposed to set up the columns ... do you see the same thing for the multi-assist case?  ALT+SHIFT+Q or ALT+SHIFT+X

Later,
PW
Comment 6 Kim Horne CLA 2007-05-15 13:38:46 EDT
Paul: They look bad in that case too.
Comment 7 Paul Webster CLA 2007-05-15 14:03:27 EDT
For a late Tuesday I build
PW
Comment 8 Paul Webster CLA 2007-05-16 11:08:55 EDT
In I20070516-0010
PW