Bug 18499 - [ExternalTools] Locations with spaces cause some tools to fail
Summary: [ExternalTools] Locations with spaces cause some tools to fail
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 major (vote)
Target Milestone: 2.0 F3   Edit
Assignee: Ryan Cooper CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
: 19515 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-05-31 14:45 EDT by Ryan Cooper CLA
Modified: 2002-09-18 13:58 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Cooper CLA 2002-05-31 14:45:31 EDT
When location arguments contain spaces, some tools don't work properly.

For example, create a project in your workspace named "Test Project" (the space 
is important). Create a file "abc.txt" in the project. Create a simple tool 
with location c:\windows\write.exe and with the argument ${resource_loc}. 
Select the file abc.txt, then run the tool. Write will try to find the file 
<workspace location>/Test and fail.
Comment 1 Nick Edgar CLA 2002-05-31 16:42:52 EDT
This is pretty important.  I think the different Runtime.exec methods handle 
arguments with spaces differently.  If I remember correctly, the ones which 
take an array of strings work better than the ones which take a single string.
Might have to quote args with spaces ourselves.
Comment 2 Nick Edgar CLA 2002-06-05 16:58:18 EDT
Need to ensure we also handle user-specified quotes properly.
Comment 3 Simon Arsenault CLA 2002-06-06 15:13:50 EDT
*** Bug 19515 has been marked as a duplicate of this bug. ***
Comment 4 Simon Arsenault CLA 2002-06-10 12:25:22 EDT
Code changes done by Ryan.
Checked by Simon and Tod
Comment 5 Ryan Cooper CLA 2002-06-12 11:22:39 EDT
Verified in build 20020610.