Bug 184792 - Cntrl-3 / New CVS Repo fails
Summary: Cntrl-3 / New CVS Repo fails
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-30 17:35 EDT by Kevin McGuire CLA
Modified: 2019-09-06 16:17 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2007-04-30 17:35:57 EDT
nightly 0429

1. Cntrl-3 brings up the universal chooser
2. type "new cvs", you will see the command to open a new CVS repo
3. choose that
You will get a class cast exception.

Doesn't matter if the CVS repo view is open or not.

Top of stack looks like:

java.lang.ClassCastException: org.eclipse.team.internal.ccvs.ui.wizards.NewLocationWizard
at org.eclipse.ui.internal.actions.NewWizardShortcutAction.run(NewWizardShortcutAction.java:87)
at org.eclipse.ui.internal.quickaccess.WizardElement.execute(WizardElement.java:41)
at org.eclipse.ui.internal.quickaccess.QuickAccessDialog.handleElementSelected(QuickAccessDialog.java:616)
at org.eclipse.ui.internal.quickaccess.QuickAccessDialog$5.widgetDefaultSelected(QuickAccessDialog.java:264)
Comment 1 Boris Bokowski CLA 2007-04-30 20:28:02 EDT
NewLocationWizard does not implement the marker interface INewWizard as required per extension point schema.
Comment 2 Michael Valenta CLA 2007-05-01 08:51:13 EDT
I have a problem here. It may be the case that the schema states that the wizard should implement INewWizard but it doesn't enforce it (i.e. there is no warning or error in my plug-in.xml) and the New Wizard Wizard doesn't require it (i.e. it works from the New Wizard). I think the workbench needs to enforce the use of INewWizard consistently (i.e. if should either work in both places or fail in both places).

I will fix this is CVS and then forward the bug to Platform/UI.
Comment 3 Michael Valenta CLA 2007-05-01 09:19:44 EDT
I've released the fix to HEAD. Reassigning to Boris to respond to my previous comments.
Comment 4 Remy Suen CLA 2009-11-29 09:29:43 EST
(In reply to comment #2)
> I have a problem here. It may be the case that the schema states that the
> wizard should implement INewWizard but it doesn't enforce it (i.e. there is no
> warning or error in my plug-in.xml)

This is odd because we do spec it in the newWizards.exsd file.

<attribute name="class" type="string" use="required">
  <annotation>
      <documentation>
        a fully qualified name of the Java class implementing &lt;samp&gt;org.eclipse.ui.INewWizard&lt;/samp&gt;.
      </documentation>
    <appinfo>
      <meta.attribute kind="java" basedOn="org.eclipse.jface.wizard.Wizard:org.eclipse.ui.INewWizard"/>
    </appinfo>
  </annotation>
</attribute>

> and the New Wizard Wizard doesn't require
> it (i.e. it works from the New Wizard). I think the workbench needs to enforce
> the use of INewWizard consistently (i.e. if should either work in both places
> or fail in both places).

This seems to be because the dialog merely casts to IWorkbenchWizard whereas Ctrl+3 casts to INewWizard.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:17:35 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.