Bug 184660 - [Operations] Compare With Branch Or Version Dialog Truncates Long Version Tags
Summary: [Operations] Compare With Branch Or Version Dialog Truncates Long Version Tags
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-04-30 00:45 EDT by nikolaus heger CLA
Modified: 2007-06-22 11:42 EDT (History)
0 users

See Also:
Michael.Valenta: review+


Attachments
Screenshot of the problem (18.81 KB, image/png)
2007-04-30 00:47 EDT, nikolaus heger CLA
no flags Details
Screenshot from 3.3m6 (33.47 KB, image/jpeg)
2007-05-04 02:56 EDT, Krzysztof Daniel CLA
no flags Details
No Filter Text - Works As Expected (3.3m7) (16.39 KB, image/png)
2007-05-06 15:09 EDT, nikolaus heger CLA
no flags Details
Fitler text-Tags appear truncated (3.3m7) (17.58 KB, image/png)
2007-05-06 15:10 EDT, nikolaus heger CLA
no flags Details
Workaround (1.40 KB, patch)
2007-05-07 06:08 EDT, Krzysztof Daniel CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nikolaus heger CLA 2007-04-30 00:45:52 EDT
Hello,

I can resize the Compare With Branch Or Version dialog horizontally, but when I make it wider, the list does not get wider as it should. As a result, long version tags like the ones we use are truncated, and thereby pretty useless. 

The version tag I am looking for is called PROPHET_ProphetCharts_2_0_b240 - there is a version tag for every build, and the only difference between them is the build number.
In the version dialog list, I see the following list:
PROPHET_ProphetCharts_2_0_...
PROPHET_ProphetCharts_2_0_...
PROPHET_ProphetCharts_2_0_...
PROPHET_ProphetCharts_2_0_...
PROPHET_ProphetCharts_2_0_...
PROPHET_ProphetCharts_2_0_...
PROPHET_ProphetCharts_2_0_...

There is no way to make the list wider. I have a screenshot but don't see any way of attaching it here.
Comment 1 nikolaus heger CLA 2007-04-30 00:47:17 EDT
Created attachment 65363 [details]
Screenshot of the problem
Comment 2 nikolaus heger CLA 2007-04-30 00:50:13 EDT
Exact Eclipse version:
Version: 3.3.0
Build id: I20061214-1445
Comment 3 Michael Valenta CLA 2007-05-03 14:18:39 EDT
Krzysztof, can you have a look at this? If the fix is trivial, we can put it into RC1.
Comment 4 Krzysztof Daniel CLA 2007-05-04 02:56:37 EDT
Created attachment 65888 [details]
Screenshot from 3.3m6

This is screenshot from 3.3m6.

Tag names are not truncated.

Worksforme.
Comment 5 Michael Valenta CLA 2007-05-04 08:40:26 EDT
Nikolaus, would it be possible for you try the 3.3 M7 build when it is available (should be out sometime today). If you still see the problem, please reopen.
Comment 6 nikolaus heger CLA 2007-05-06 15:09:31 EDT
Created attachment 66034 [details]
No Filter Text - Works As Expected (3.3m7)
Comment 7 nikolaus heger CLA 2007-05-06 15:10:49 EDT
Created attachment 66035 [details]
Fitler text-Tags appear truncated (3.3m7)
Comment 8 nikolaus heger CLA 2007-05-06 15:12:42 EDT
Sorry, this is not resolved. 

Tested with Eclpse 3.3m7

Steps to reproduce:
1) create two tags, one called Very_long_name_tag_where_does_it_end_1, the second called Very_long_name_tag_where_does_it_end_2
2) Right click on the project -> Replace with Another branch or version
3) In Compare With Branch Or Version dialog, click "Refresh Tags"
4) Type "Very_" in the text field on the top of the dialog

Expected: Resulting list fills the dialog and has a horizontal scroll bar if tags are too long
Actual: Resulting list is truncated around character 30, the rest of the tag does not display. See screen shot 2.
Regression: Resizing the dialog does not help
Regression 2: As long as no text is in the text field on top of the dialog, the tags display as expected. See screen shot 1. 
Comment 9 Krzysztof Daniel CLA 2007-05-07 06:08:03 EDT
Created attachment 66069 [details]
Workaround

I am afraid nothing significant can be done in this area.

The tag column width is calculated on string length in characters times *average* character length.

And this is the problem, since when text is longer than calculated, is being truncated.

Or, maybe is there any way of calculation string length based on its content?
Comment 10 Michael Valenta CLA 2007-05-07 14:36:15 EDT
Patch reviewed and released. I reduce the safety margin to 50. I think 50 is enough and having it shorter may reduce the chances of the horizontal scroll bar appearing.