Bug 184597 - [Contributions] ActionContributionItem should show accelerator text even if accelerator cannot be parsed
Summary: [Contributions] ActionContributionItem should show accelerator text even if a...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks: 181830
  Show dependency tree
 
Reported: 2007-04-28 08:30 EDT by Markus Keller CLA
Modified: 2007-06-06 15:41 EDT (History)
0 users

See Also:

Attachments
Fix (1.34 KB, patch)
2007-04-28 08:31 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-04-28 08:30:26 EDT 
HEAD

ActionContributionItem should show the accelerator text for a MenuItem even if the accelerator cannot be parsed.

I'm currently aware of two situations where Action#setText(..) cannot correctly parse the accelerator (via LegacyActionTools.convertLocalizedAccelerator(..)):
- bug 184594 (LegacyActionTools broken on carbon)
- accelerators that consist of multiple key strokes

An example of the second problem can be seen if you remap "Refactor > Rename" to "Alt+Shift+R, R" and then open the menu of the in-place rename refactoring popup as shown in attachment 65224 [details] of bug 181830 (> 2007-04-27, not yet available in an I-build).
Comment 1 Markus Keller CLA 2007-04-28 08:31:58 EDT 
Created attachment 65324 [details]
Fix

The fix makes sure the acceleratorText is shown unmodified (if available).
Comment 2 Markus Keller CLA 2007-04-28 08:34:51 EDT 
This should be fixed for M7.
Comment 3 Paul Webster CLA 2007-04-30 11:33:03 EDT 
Released Markus' patch in HEAD >20070430-1130

PW
Comment 4 Paul Webster CLA 2007-05-01 17:03:34 EDT 
In I20070501-0010
PW