Bug 184074 - [MPE] Need API to disable key bindings in shared editor header
Summary: [MPE] Need API to disable key bindings in shared editor header
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 204769 210753
Blocks: 177334 210793 211610
  Show dependency tree
 
Reported: 2007-04-25 13:57 EDT by Curtis d'Entremont CLA
Modified: 2007-12-11 12:45 EST (History)
3 users (show)

See Also:

Attachments
MultiPageEditorPart v01 (7.90 KB, patch)
2007-11-23 10:06 EST, Paul Webster CLA 		no flags Details | Diff
SharedHeaderFormEditor v01 (2.27 KB, patch)
2007-11-23 10:07 EST, Paul Webster CLA 		no flags Details | Diff
MultiPageEditorPart v02 (13.34 KB, patch)
2007-11-28 15:23 EST, Paul Webster CLA 		no flags Details | Diff
SharedHeaderFormEditor v02 (7.81 KB, patch)
2007-11-28 15:25 EST, Paul Webster CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis d'Entremont CLA 2007-04-25 13:57:41 EDT 
Based on discussion in bug 177331.

Forms extends MultiPageEditorPart and provides an editor that has a shared header - the same header for all the editor pages. The header allows clients to add fields, e.g. text fields.

If the current editor page is a text editor, and the focus is in one of the fields in the header, we want to turn off the key bindings that would apply to the text editor (only those). Currently we are using internal code, doing it the same way as MultiPageEditorPart.

We are using:

(internal,provisional) org.eclipse.ui.internal.services.INestable
(deprecated) org.eclipse.ui.IKeyBindingService
(deprecated) org.eclipse.ui.INestableKeyBindingService;

Need a way to do this using only non-deprecated API.
Comment 1 Paul Webster CLA 2007-11-23 10:06:17 EST 
Created attachment 83642 [details]
MultiPageEditorPart v01

API that allows someone overridding createPageContainer(*) to temporarily suspend the active page site.

PW
Comment 2 Paul Webster CLA 2007-11-23 10:07:03 EST 
Created attachment 83643 [details]
SharedHeaderFormEditor v01

Matching patch for the MPEPv01 that uses the activateSite/deactivateSite functionality.

PW
Comment 3 Paul Webster CLA 2007-11-28 15:23:00 EST 
Created attachment 84012 [details]
MultiPageEditorPart v02

API for activating/deactivating sites, with support for Bug 177334 roled into it.

PW
Comment 4 Paul Webster CLA 2007-11-28 15:25:29 EST 
Created attachment 84013 [details]
SharedHeaderFormEditor v02

The shared header editor uses the new API, plus Bug 210753

PW
Comment 5 Paul Webster CLA 2007-11-28 15:27:32 EST 
(In reply to comment #3)
> Created an attachment (id=84012) [details]
> MultiPageEditorPart v02

Also includes fix for Bug 204769

PW
Comment 6 Paul Webster CLA 2007-11-30 12:08:43 EST 
(In reply to comment #3)
> Created an attachment (id=84012) [details]
> MultiPageEditorPart v02
> 
> API for activating/deactivating sites, with support for Bug 177334 roled into
> it.

Released to HEAD >20071130
PW
Comment 7 Paul Webster CLA 2007-12-11 12:45:32 EST 
In I20071211-0010
PW