Bug 184057 - Add drag and drop to expression view.
Summary: Add drag and drop to expression view.
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 29494 (view as bug list)
Depends on:
Blocks: 175584
  Show dependency tree
 
Reported: 2007-04-25 12:51 EDT by Pawel Piech CLA
Modified: 2007-06-25 13:48 EDT (History)
2 users (show)

See Also:


Attachments
Patch adding drag and drop to expression view (based on HEAD as of April 27,2007). (16.20 KB, patch)
2007-04-27 13:07 EDT, Pawel Piech CLA
no flags Details | Diff
Updated patch as of June 11, 2007. (32.08 KB, patch)
2007-06-11 14:57 EDT, Pawel Piech CLA
no flags Details | Diff
Updated patch (21.40 KB, patch)
2007-06-22 12:36 EDT, Curtis Windatt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2007-04-25 12:51:42 EDT
Many IDEs provide the ability to drag variables from the locals and registers views to the watch view, as well as to drag text from the editor to the watch view. 

Come to think of it, I'm rather surprised that Eclipse doesn't provide this functionality already.  I'm even more surprised that there aren't any enhancment requests for it that I could find.  Has anybody asked for this functionality in the past?
Comment 1 Darin Wright CLA 2007-04-25 22:20:21 EDT
Bug 127874 mentions drag and drop between all debug views. However, since this request is more specific, I will leave it open. Marking as assigned for future consideration.
Comment 2 Pawel Piech CLA 2007-04-27 13:07:06 EDT
Created attachment 65235 [details]
Patch adding drag and drop to expression view (based on HEAD as of April 27,2007).

The attached patch enables dragging of variables from variables and registers views into the expressions view.  And dragging of text from anywhere into the expression view.

The needed changes are actually pretty straight-forward and re-use the APIs from WatchAction.

I know it's probably rather late for 3.3 for this kind of workflow change, but I figured it's still worth a try :-)
Comment 3 Pawel Piech CLA 2007-06-11 14:57:45 EDT
Created attachment 70882 [details]
Updated patch as of June 11, 2007.  

This patch is combined with the patch for allowing alternative content providers for expression view from bug 184233.  Hopefully they both can be addressed :-)
Comment 4 Curtis Windatt CLA 2007-06-12 14:32:44 EDT
The drag and drop portion of the patch is reasonable, so this bug is being marked as a possible 3.4 candidate.  The javadoc needs to be improved before applying.  We also need to consider what other dragging/dropping functionality we may want to add to the debug views during 3.4 and what effect it might have on this patch.

The patch for alternative content providers needs to be separated and dealt with separately in bug 184233.
Comment 5 Pawel Piech CLA 2007-06-12 14:41:23 EDT
One often requested feature in our debugger is to drag variables, expressions, and stack frames into the memory view, in order to create a new memory monitor at that location.  

Another useful feature may be to drag stack frames, variables, and expressions into the breakpoint view to create a breakpoints.  

Both would probably require some new APIs though.
Comment 6 Darin Wright CLA 2007-06-12 15:19:43 EDT
*** Bug 29494 has been marked as a duplicate of this bug. ***
Comment 7 Curtis Windatt CLA 2007-06-22 12:36:54 EDT
Created attachment 72193 [details]
Updated patch

Separated drag/drop component from patch.  Fixed minor issues, added documentation, updated copyrights.
Comment 8 Curtis Windatt CLA 2007-06-22 12:38:58 EDT
Applied updated patch.  Marking as contributed.

Pawel, please review the changes, including copyright updates.
Comment 9 Curtis Windatt CLA 2007-06-22 12:39:58 EDT
Reopening to assign to Darin for verification.
Comment 10 Curtis Windatt CLA 2007-06-22 12:40:31 EDT
Darin, please verify.
Comment 11 Curtis Windatt CLA 2007-06-22 12:41:16 EDT
Fixed for 3.4 M1
Comment 12 Pawel Piech CLA 2007-06-22 12:53:33 EDT
Looks good to me.  
Thank You!
Comment 13 Darin Wright CLA 2007-06-25 13:48:37 EDT
Verified.