Community
Participate
Working Groups
I20070424-0930. The source for various plug-ins (e.g. org.junit, com.ibm.icu) is no longer present. This blocks me from working with these.
A problem could be that the orbit bundles include a .qualifier in the bundle version (e.g. org.junit_3.8.2 has changed to org.junit_3.8.2.v200701261102, etc.)
I have released a fix to our builder for the icu issue. I have opened a bug 184026 against orbit for the missing source from the junit 3.8.2 bundle.
I'm testing a new pde build + new Orbit source bundles that DJ has provided to address this bug.
The necessary changes were not put into the Orbit builder so the source bundles are not part of the latest Orbit stable build. That is why we sent Kim manually created bundles. She has been running test builds with these bundles all day but there have been minor issues which have prevented a successful build from happening. The changes that she has been making to the builder are in a separate stream and will have to be integrated into the main builder at some point. Therefore rather than risk reducing the stability of RC1 by doing this tomorrow, we have decided that we will have to live with no source for RC1.
*** Bug 188602 has been marked as a duplicate of this bug. ***
DJ, Pascal, please +1 this bug when the Orbit stable build has the correct source bundles. thanks :-)
http://download.eclipse.org/tools/orbit/downloads/drops/S200705240148/ This build is good. Thanks.
Created attachment 68598 [details] patch to consume new orbit source bundles + latest Orbit stable build
released for 1pm build
I have confirmed that all the source is in the 1pm build except for Ant, which Kim is going to fix and release for the next build.
I've confirmed that the ant source is included in I20070524-1800.
>I have confirmed that all the source is in the 1pm build except for Ant That's not what I see: as of I20070525-0010 JUnit and Ant source are back but there is at least the source of 'com.ibm.icu' still missing.
In I20070525-0010, I get a lot of compile errors when I import all plug-ins as source: - for javax.servlet, the source folder is not correctly set - source plug-ins must set the singleton directive in the Manifest.mf
Regarding comment #12, I've released a fix for this and am running a test build. We have a hack in our builds to delete all the source* after checkout because there of a historical issue with pde build. I excluded all the orbit bundles from this but it was very a brittle approach. In any case, I've deleted the hack that deletes source and am testing to see if the issue has been resolved in pde build.
Regarding comment #14, this wasn't the problem. There is an issue with including the icu.source plugin in the generated rcp feature which is causing this - Pascal and I will investigate.
Talked to Pascal, and the issue is that the com.ibm.icu.source bundle is never fetched due to our feature organization. In any case, as his suggested workaround, I've added this bundle to the master feature so it will be fetched and available on the filesystem for inclusion in the build. If we have another build, it will be included in RC2, if not next week's RC edition.
(In reply to comment #13) > In I20070525-0010, I get a lot of compile errors when I import all plug-ins as > source: [..] I've opened bug 189640 for problems with importing orbit plug-ins as source.
As of I20070529-0010 it seems that the ICU source is again part of the drop but the PDE importer fails to attach the correct source.
The icu source is now in an unjarred format in the SDK, I released a change to the platform feature to address this issue and ran a test build.
This works in I20070530-0010. Thanks.
I think I can close this bug now, the other issues regarding importing as source are reported as separate bugs.
.
