Bug 183796 - JobDetailsView - after code cleanup
Summary: JobDetailsView - after code cleanup
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Geclipse (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mathias Stümpert CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-04-24 10:52 EDT by Mariusz Wojtysiak CLA
Modified: 2014-01-09 16:18 EST (History)
0 users

See Also:

Attachments
Patch to apply (39.70 KB, patch)
2007-04-24 10:53 EDT, Mariusz Wojtysiak CLA 		no flags Details | Diff
Patch with corrected package name (38.65 KB, patch)
2007-04-26 04:18 EDT, Mariusz Wojtysiak CLA 		aog-ecl: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mariusz Wojtysiak CLA 2007-04-24 10:52:28 EDT 
- old class GridJobDetailsView was removed
- code from GridJobDetailsView was divided into separate classes in eu.geclipse.ui.views.JobDetails
- unimplemented sections were removed
- contain sections General and description for IGridJob and IGridJobDescription
Comment 1 Mariusz Wojtysiak CLA 2007-04-24 10:53:18 EDT 
Created attachment 64746 [details]
Patch to apply

Please notice I deleted file GridJobDetailsView.java
Comment 2 Mathias Stümpert CLA 2007-04-24 10:59:08 EDT 
The patch is not conform to our coding conventions. Please rename your package JobDetails to only contain lower case characters and reattach the corrected patch.
Comment 3 Mariusz Wojtysiak CLA 2007-04-26 04:18:54 EDT 
Created attachment 64985 [details]
Patch with corrected package name
Comment 4 Mathias Stümpert CLA 2007-04-26 06:46:15 EDT 
patch applied and committed
Comment 5 Mathias Stümpert CLA 2007-05-31 07:39:55 EDT 
closing this ticket
Comment 6 Ariel Garcia CLA 2009-05-03 09:01:36 EDT 
Comment on attachment 64985 [details]
Patch with corrected package name

Applied by Mathias