Bug 18351 - [Dialogs] Buttons on switch to editor dialog are too small
Summary: [Dialogs] Buttons on switch to editor dialog are too small
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2002-05-30 14:10 EDT by Randy Giffen CLA
Modified: 2005-05-10 14:55 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Giffen CLA 2002-05-30 14:10:37 EDT
Should set same min size as in Dialog.createButton
Comment 1 Nick Edgar CLA 2002-05-30 14:40:45 EDT
Not sure what you mean.  They look OK to me.
Comment 2 Randy Giffen CLA 2002-05-31 10:29:32 EDT
They are too short. Compare to the OK Cancel buttons.
Comment 3 Nick Edgar CLA 2002-05-31 19:58:34 EDT
You must mean height.  I was thinking width.
Would you mind fixing them up?
Comment 4 Nick Edgar CLA 2002-05-31 19:59:49 EDT
Are we setting the height of buttons in a way that will allow for fonts of 
different sizes (e.g. large fonts setting)?

I think the use of the width and height constants in IDialogConstants could 
lead to some accessibility issues if they hardcode pixel dimensions that are 
too small for large fonts.
Comment 5 Randy Giffen CLA 2002-06-03 09:31:14 EDT
IDialogConstants values are in dialog units which are font independent.
convert*DLUsToPixels is used to convert these to pixels.

Comment 6 Nick Edgar CLA 2002-06-03 09:42:05 EDT
Candidate for fix pass 2.
Comment 7 Randy Giffen CLA 2002-06-06 13:03:45 EDT
We have similar problems with button sizes in the import export wizards and 
perhaps elsewhere. Suggest defer until after 2.0
Comment 8 Nick Edgar CLA 2002-06-06 13:47:06 EDT
Deferring
Comment 9 Randy Giffen CLA 2002-08-12 10:37:59 EDT
Reopened for investigation
Comment 10 Tod Creasey CLA 2002-10-22 08:24:33 EDT
Fixed in build >20021022
Comment 11 Tod Creasey CLA 2005-05-10 14:55:56 EDT
Marking closed