Bug 183396 - [CellEditors] Make DialogCellEditor more easily extensible
Summary: [CellEditors] Make DialogCellEditor more easily extensible
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, helpwanted
Depends on:
Blocks:
 
Reported: 2007-04-20 11:03 EDT by Alanna Zito CLA
Modified: 2019-09-06 16:13 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alanna Zito CLA 2007-04-20 11:03:17 EDT
Build ID:  I20070410-1043

Steps To Reproduce:
A few changes to DialogCellEditor would make it much easier to extend:

1) DialogCellLayout should be made protected or public.
2) There should be a way to override the selection listener on the button without having to override and copy the entire createControl method.  It's especially difficult to override this method because it uses the DialogCellLayout, which is not accessible to subclasses.  

Reason:
I needed a cell editor that looks and behaves almost exactly like a DialogCellEditor; however, when the button is pressed, instead of launching the dialog right away, my cell editor displays a small context menu of frequently used choices, plus a "More..." option to launch the full dialog.  The only way to change the selection behaviour on the button was to override the createControl method, which meant that I needed to copy the entire method just to changed the selection listener.  Since this method is also where the layout is set, I needed to copy the DialogCellLayout class since it wasn't accessible to subclasses..
Comment 1 Boris Bokowski CLA 2007-04-20 11:51:29 EDT
Since we are past the API freeze, we can only address this in 3.4.
Comment 2 Eclipse Webmaster CLA 2019-09-06 16:13:17 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.