Bug 182920 - [History View] Use SWT.SEARCH style on history view search field
Summary: [History View] Use SWT.SEARCH style on history view search field
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords:
Depends on: 182914 260361
Blocks:
  Show dependency tree
 
Reported: 2007-04-18 06:38 EDT by Brock Janiczak CLA
Modified: 2009-03-16 10:59 EDT (History)
1 user (show)

See Also:

Attachments
patch to CVSHistoryPage (1.74 KB, patch)
2007-04-18 06:39 EDT, Brock Janiczak CLA 		no flags Details | Diff
Fix v01 (1.35 KB, patch)
2009-03-16 10:57 EDT, Szymon Brandys CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brock Janiczak CLA 2007-04-18 06:38:54 EDT 
Version: 3.3.0
Build id: I20070323-1616

The search field of the CVS history view does not use setMessage to display the search message to the user.  The attached patch will selectively call Text#setMessage if the text field reports that it supports the SEARCH style bit.  It will continue to call setText if the style bit is not supported.

I have only tested on XP as that is all i have access to.  You should see the old behaviour on windows 2000.
Comment 1 Brock Janiczak CLA 2007-04-18 06:39:37 EDT 
Created attachment 64156 [details]
patch to CVSHistoryPage
Comment 2 Michael Valenta CLA 2007-04-18 11:47:08 EDT 
I tried it on XP and the initial message never appears (i.e. "Enter search term" is not displayed when the field is empty). Did this work for you?
Comment 3 Brock Janiczak CLA 2007-04-18 16:34:28 EDT 
do you have the east asian language pack installed? see bug 182914
Comment 4 Michael Valenta CLA 2007-04-30 10:32:17 EDT 
Perhaps I do (i.e. I didn't explicitly install them but they may be there). I would like to wait to see what the resolution of bug 182914 is before submitting the patch.
Comment 5 Szymon Brandys CLA 2008-04-16 04:54:43 EDT 
As Mike wrote in the comment 4, we will wait till the blocking bug is fixed.
Comment 6 Szymon Brandys CLA 2009-03-16 10:57:12 EDT 
Created attachment 128925 [details]
Fix v01

In fact, the fix is easier now.
Comment 7 Szymon Brandys CLA 2009-03-16 10:59:04 EDT 
Released to HEAD.