Bug 182898 - [KeyBindings] IAE trying to open Keys (Experimental) preference page
Summary: [KeyBindings] IAE trying to open Keys (Experimental) preference page
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: ali sheraz CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, polish
Depends on:
Blocks:
 
Reported: 2007-04-18 05:05 EDT by Markus Keller CLA
Modified: 2007-06-06 08:14 EDT (History)
1 user (show)

See Also:


Attachments
Keys preferences (12.62 KB, text/plain)
2007-04-18 08:17 EDT, Markus Keller CLA
no flags Details
Bug-Fix (3.79 KB, patch)
2007-04-19 15:02 EDT, ali sheraz CLA
no flags Details | Diff
Bug-Fix (5.24 KB, patch)
2007-04-20 13:56 EDT, ali sheraz CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-04-18 05:05:05 EDT
I20070417-0800

Just tried to open Keys (Experimental) preference page.

java.lang.IllegalArgumentException
at sun.text.normalizer.ReplaceableUCharacterIterator.<init>(ReplaceableUCharacterIterator.java:42)
at sun.text.normalizer.UCharacterIterator.getInstance(UCharacterIterator.java:66)
at sun.text.normalizer.NormalizerBase.setText(NormalizerBase.java:985)
at java.text.CollationElementIterator.setText(CollationElementIterator.java:480)
at java.text.RuleBasedCollator.compare(RuleBasedCollator.java:348)
at java.text.Collator.compare(Collator.java:310)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage$BindingComparator.compare(NewKeysPreferencePage.java:610)
at org.eclipse.jface.viewers.ViewerComparator$1.compare(ViewerComparator.java:187)
at java.util.Arrays.mergeSort(Arrays.java:1270)
at java.util.Arrays.mergeSort(Arrays.java:1282)
at java.util.Arrays.mergeSort(Arrays.java:1281)
at java.util.Arrays.mergeSort(Arrays.java:1282)
at java.util.Arrays.mergeSort(Arrays.java:1281)
at java.util.Arrays.mergeSort(Arrays.java:1282)
at java.util.Arrays.mergeSort(Arrays.java:1282)
at java.util.Arrays.sort(Arrays.java:1210)
at org.eclipse.jface.viewers.ViewerComparator.sort(ViewerComparator.java:185)
at org.eclipse.jface.viewers.AbstractTreeViewer.getSortedChildren(AbstractTreeViewer.java:603)
at org.eclipse.jface.viewers.AbstractTreeViewer$1.run(AbstractTreeViewer.java:774)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:751)
at org.eclipse.jface.viewers.TreeViewer.createChildren(TreeViewer.java:495)
at org.eclipse.jface.viewers.AbstractTreeViewer.internalInitializeTree(AbstractTreeViewer.java:1420)
at org.eclipse.jface.viewers.TreeViewer.internalInitializeTree(TreeViewer.java:674)
at org.eclipse.jface.viewers.AbstractTreeViewer$5.run(AbstractTreeViewer.java:1407)
at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1333)
at org.eclipse.jface.viewers.AbstractTreeViewer.inputChanged(AbstractTreeViewer.java:1396)
at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:251)
at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1624)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage.updateTree(NewKeysPreferencePage.java:1895)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage.update(NewKeysPreferencePage.java:1677)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage.selectSchemeCombo(NewKeysPreferencePage.java:1596)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage.access$7(NewKeysPreferencePage.java:1586)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage$4.selectionChanged(NewKeysPreferencePage.java:1133)
at org.eclipse.jface.viewers.Viewer$2.run(Viewer.java:162)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at org.eclipse.core.runtime.Platform.run(Platform.java:850)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:45)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:187)
at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:160)
at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2058)
at org.eclipse.jface.viewers.StructuredViewer.setSelection(StructuredViewer.java:1659)
at org.eclipse.jface.viewers.Viewer.setSelection(Viewer.java:392)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage.setScheme(NewKeysPreferencePage.java:1669)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage.fill(NewKeysPreferencePage.java:1369)
at org.eclipse.ui.internal.keys.NewKeysPreferencePage.createContents(NewKeysPreferencePage.java:944)
at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:233)
at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1438)
at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:1195)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at org.eclipse.core.runtime.Platform.run(Platform.java:850)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:45)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:187)
at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1189)
at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.showPage(FilteredPreferenceDialog.java:433)
at org.eclipse.jface.preference.PreferenceDialog$9.selectionChanged(PreferenceDialog.java:694)
at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:842)
at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at org.eclipse.core.runtime.Platform.run(Platform.java:850)
at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:45)
at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:187)
at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:840)
at org.eclipse.jface.viewers.StructuredViewer.handlePostSelect(StructuredViewer.java:1153)
at org.eclipse.jface.viewers.StructuredViewer$5.widgetSelected(StructuredViewer.java:1173)
at org.eclipse.jface.util.OpenStrategy.firePostSelectionEvent(OpenStrategy.java:250)
at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:244)
at org.eclipse.jface.util.OpenStrategy$3.run(OpenStrategy.java:418)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:123)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3650)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3287)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:820)
at org.eclipse.jface.window.Window.open(Window.java:796)
at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:65)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:545)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3673)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3284)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2365)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2329)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2204)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:101)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:153)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:359)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:174)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:475)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:415)
at org.eclipse.equinox.launcher.Main.run(Main.java:1140)
at org.eclipse.equinox.launcher.Main.main(Main.java:1115)
Comment 1 Paul Webster CLA 2007-04-18 07:09:49 EDT
Ali, please take a look at this.
PW
Comment 2 Paul Webster CLA 2007-04-18 07:12:07 EDT
Markus, when I open the page it works fine.

Could you please export your keybinding preferences and attach?

Thanx,
PW
Comment 3 Markus Keller CLA 2007-04-18 08:17:36 EDT
Created attachment 64167 [details]
Keys preferences
Comment 4 ali sheraz CLA 2007-04-19 15:02:02 EDT
Created attachment 64338 [details]
Bug-Fix

Paul, 

I have attached the patch which fixes this bug. (Changes made according to the points we discussed).

Ali
Comment 5 Paul Webster CLA 2007-04-20 12:46:45 EDT
(In reply to comment #4)
> Created an attachment (id=64338) [details]
> Bug-Fix
>

Ali, the fix looks good but could you re-spin using NewKeysPreferenceMessages for localization instead of those constants.  Check out other uses of this class in the preference page and the NewKeysPreferencePage.properties.

PW
Comment 6 ali sheraz CLA 2007-04-20 13:56:29 EDT
Created attachment 64479 [details]
Bug-Fix

Paul,

This is the updated patch.

Ali
Comment 7 Paul Webster CLA 2007-04-20 14:29:10 EDT
(In reply to comment #6)
> Created an attachment (id=64479) [details]
> Bug-Fix
>

Released to HEAD >20070420
PW
Comment 8 Paul Webster CLA 2007-04-24 20:19:20 EDT
>20070420
PW
Comment 9 Paul Webster CLA 2007-05-01 08:29:06 EDT
In I20070501-0010
PW