Community
Participate
Working Groups
Build ID: I20070222-0951 Steps To Reproduce: TPTP modifications for the below mentioned requirements. 1. Improve the error message. The message should state that the log could notbe imported and does not seem to match the adapter. If we are dependent on adapter providers, for the contents, we need a best practice for writing understandable messages. 2. Once the import fails, the log is still shown in the left navigation, butcannot be modified. Users should be able to right-click on the file and changethe filter in order to reimport the file. More information:
Consolidated patch for Bugzilla's 182984, 182872, 182871 for the packages org.eclipse.hyades.logging.parsers and org.eclipse.hyades.logging.adapter has been attached to Bugzilla 182984
I suspect this defect is against the GLA Run-time so I am changing the component to Monitor.Execution. Monitor.UI.GLARules is for the GLA Editor.
I am deferring this to future because it requires PII changes and PII is frozen in TPTP 4.4. More investigation of the suggested patch is required.
Here is more explanation from Hari regarding the proposed fix and scenarios addressed: The purpose of the LogParserExceptionHandler class is to accumulate exception messages while parsing and throw the final exception message after a threshold is reached or after all parsing is completed. We want to be able to display meaningful error messages for the following scenarios :- 1) While importing an empty log file 2) While importing inappropriate logs (caused either due to wrong selection of the version of the log or due to the wrong selection of the log type itself) 3) While importing a correct log file, if exceptions occur while parsing some line(s), we would want to show the user the exact line and line-number at which the exception occurs so that they could provide the same information to the support personnel. If this situation occurs we would not want to stop parsing all- together but we would like to accumulate the exceptions generated by these few lines but still be able to import the remainder of the log and in the end show the final exception message.
This is required from AC perspective
Added sizing. Since coding is mostly done (included in patch for org.eclipse.hyades.logging.parsers attached to https://bugs.eclipse.org/bugs/show_bug.cgi?id=182984), the majority of work involved is testing in both the log import and standalone scenarios.
Created attachment 88592 [details] Adapter Failure handling patch Reviewed and updated patch with the failure handling code. Tested.
Fixed in HEAD
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
