Bug 182768 - Internal usage of gridElementCreator extension point
Summary: Internal usage of gridElementCreator extension point
Status: CLOSED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Geclipse (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Mathias Stümpert CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2007-04-17 11:17 EDT by Markus Knauer CLA
Modified: 2014-01-09 16:17 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Knauer CLA 2007-04-17 11:17:03 EDT
The extension point eu.geclipse.core.gridElementCreator is used by many external implementations (e.g. GliteJobCreator), but it is not used in internal implementations like GridConnectionCreator.

Eat-your-own-dog-food... is there any reason NOT to use the extension point internally? If there is no reason, we should use the extension point internally as well and remove the direct calls.
Comment 1 Markus Knauer CLA 2007-04-17 11:26:45 EDT
Or let me comment on that... in our code is an implicit hierarchy: First external creators, then (if none is found) internal creators. Is this really what we want -- or more precise: What happens if more than one creator is available for a specific type? 
Comment 2 Mathias Stümpert CLA 2007-04-19 06:50:09 EDT
Yes, this behaviour is on purpose. The point is that if the internal implementations should catch all causes where no explicitely defined "third-party" creator could be found since they implement "standard behaviours" like ordinary files and folders. That means that they have to be applied at the very end of the creation process when all other possibilities to create a Grid element failed. If they would be part of the extension point mechanism it would not be sure that they would be queried at the very end of the process. The result would be that for instance jobs would maybe not be created as jobs but as ordinary folders.
Comment 3 Mathias Stümpert CLA 2007-04-24 04:15:30 EDT
Markus, is this explanation satisfactory for you. Can we close that bug or would you like to leave it open for further discussion?
Comment 4 Markus Knauer CLA 2007-04-28 09:02:10 EDT
I am closing this issue. It's neither critical, nor does it break anything.
Comment 5 Markus Knauer CLA 2007-04-28 09:02:41 EDT
Closed with the M3 release