Bug 182525 - [EditorMgmt] FileEditorInput.getStorage() API change
Summary: [EditorMgmt] FileEditorInput.getStorage() API change
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2007-04-16 06:07 EDT by Valentin Zaharescu CLA
Modified: 2007-05-03 13:29 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Zaharescu CLA 2007-04-16 06:07:37 EDT 
Eclipse 3.3 M6

The implementation of getStorage() in FileEditorInput has changed to no longer throw a CoreException. Since this class is public this change may brake existing code.

This change was already done before (for 3.1 M6) and reported at that time as Bug 90698.
Comment 1 Boris Bokowski CLA 2007-04-16 10:08:02 EDT 
This is a binary compatible change, but you are right that it may break existing client code upon recompilation.

We are not too concerned about source-level incompatibilities if the changes required are local. In particular, at this point in the 3.3 development cycle, given that we are past the API freeze, I would rather not change any API unless absolutely necessary.

For reference, see http://wiki.eclipse.org/index.php/Evolving_Java-based_APIs#A_Word_about_Source_Code_Incompatibilities
Comment 2 Boris Bokowski CLA 2007-04-16 10:08:23 EDT 
This is a binary compatible change, but you are right that it may break existing client code upon recompilation.

We are not too concerned about source-level incompatibilities if the changes required are local. In particular, at this point in the 3.3 development cycle, given that we are past the API freeze, I would rather not change any API unless absolutely necessary.

For reference, see http://wiki.eclipse.org/index.php/Evolving_Java-based_APIs#A_Word_about_Source_Code_Incompatibilities
Comment 3 John Arthorne CLA 2007-04-16 10:22:38 EDT 
This was an unfortunate change, as it looks like I did this accidentally while cleaning up compiler warnings in the code. However, I agree with Boris that this is a binary-compatible change and it's too late to introduce a non source-compatible change this close to the release. It has been like this since 3.3 M4. The good news is that there was never any possibility of this method throwing an exception, so it's now a bit easier to use.
Comment 4 John Arthorne CLA 2007-04-16 10:23:21 EDT 
Reopening to document change.
Comment 5 John Arthorne CLA 2007-04-16 10:24:18 EDT 
I will add an entry to the 3.3 porting guide for this.
Comment 6 John Arthorne CLA 2007-04-16 11:24:58 EDT 
Fixed.
Comment 7 John Arthorne CLA 2007-05-03 13:29:00 EDT 
Verified porting guide entry in I20070501-0010.