Community
Participate
Working Groups
In the old objectContribution world, the contribution manager (through the LegacyResourceSupport) would make use of the IContributorResourceAdapter (and IContributorResourceAdapter2) interfaces to adapt objects to resources. The visibility expressions for resource based object contributions depended on this to ensure their menus appeared when appropriate. In the new menuContribution/handler world, the expressions framework only knows how to adapt things directly. What we need is some sort of expression that does the adaptation provided by the IContributorResourceAdapter(2) interface. Without this, repository providers (e.g CVS) will not be able to convert their objectContributions to menuContributions/handlers.
There is an internal ISelectionConversionService (that currently doesn't do much). The selection that's passed in an IEvaluationContext is the IStructuredSelection right out of the viewer. The ISelectionConversionService could provide a collection of IResources or a ResourceMapping for any incoming ISelection(IStructuredSelection). Another potential solution would be to use <resolve variable="selection" args="LegacyResourceSupport"> ... whatever ...</resolve> The IDE could provide an IVariableResolver that could take the ISelection and run it through similar convolutions that are currently done by the ObjectContributionManager. PW
Updated as per http://wiki.eclipse.org/Platform_UI/Bug_Triage PW
This is a gap that needs to be closed to support more object contribution like functionality in commands. PW
Created attachment 156545 [details] Use a resolver v01 This is not likely to succeed, because the context that has the variable is not necessarily the context that has the resolver, and the resolver cannot access the original context to retrieve the request variable. PW
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
