Bug 18193 - Error occurred during one-click update
Summary: Error occurred during one-click update
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows NT
: P1 major (vote)
Target Milestone: 2.0 F2   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-29 12:02 EDT by Dave Thomson CLA
Modified: 2002-05-31 19:08 EDT (History)
2 users (show)

See Also:


Attachments
Bitmap showing error (915.51 KB, image/bmp)
2002-05-29 12:03 EDT, Dave Thomson CLA
no flags Details
workspace (forgot to mention in steps I deleted the delta so is not in the zip) (58.40 KB, application/zip)
2002-05-29 14:34 EDT, Vlad Klicnik CLA
no flags Details
New Message if a file is remotely missing [GIF] (6.88 KB, image/gif)
2002-05-29 19:23 EDT, Christophe Elek CLA
no flags Details
"flat" features with update URL pointing to shrek (11.20 KB, application/zip)
2002-05-30 14:24 EDT, Vlad Klicnik CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Thomson CLA 2002-05-29 12:02:24 EDT
Build 0528
Help->New Updates
Press Finish
Answer all warnings with affirmative i.e. proceed to install.
Error occurred.  See attached bitmap to see the error.  This looks to me like 
some kind of communication problem, but I think the error is unhelpful to a 
user.  I will try it again to see if it is repeatable.

Here is the text from the message (note this is a single very long line - may 
be a problem with line terminators also:
---------------
Error retrieving plugins/org.eclipse.help.webapp_2.0.0.jar in Archive Reference 
No Reference at location 
http://update.eclipse.org/updates/features/org.eclipse.platform_2.0.0.2002052711
01.jar. Unable to access plugins/org.eclipse.help.webapp_2.0.0.jar.
[java.io.FileNotFoundException: 
http://update.eclipse.org/updates/plugins/org.eclipse.help.webapp_2.0.0.jar]
-------------------------

Here is the Log:

!SESSION May 29, 2002 11:13:19.781 ---------------------------------------------
java.fullversion=J2RE 1.3.1 IBM Windows 32 build cn131-20020403 (JIT enabled: 
jitc)
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Command-line arguments: -os win32 -ws win32 -arch x86 -install 
file:C:/WINNT/Profiles/Administrator/Desktop/0529/eclipse/
!ENTRY org.eclipse.core.runtime 2 1 May 29, 2002 11:13:19.781
!MESSAGE Problems encountered loading the plug-in registry.
!SUBENTRY 1 org.eclipse.core.runtime 2 1 May 29, 2002 11:13:19.781
!MESSAGE Unknown extension point 
org.eclipse.debug.ui.launchConfigurationShortcuts specified in plug-in 
org.eclipse.pde.ui.
!SESSION May 29, 2002 11:13:40.137 ---------------------------------------------
java.fullversion=J2RE 1.3.1 IBM Windows 32 build cn131-20020403 (JIT enabled: 
jitc)
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Command-line arguments: -os win32 -ws win32 -arch x86 -feature 
org.eclipse.platform -install 
file:C:/WINNT/Profiles/Administrator/Desktop/0529/eclipse/
!ENTRY org.eclipse.core.resources 1 4 May 29, 2002 11:13:40.137
!MESSAGE Reference action not found: additions
!ENTRY org.eclipse.update.core 4 0 May 29, 2002 12:08:41.299
!MESSAGE Unable to complete action for feature "Eclipse Platform" due to errors.
!STACK 1
org.eclipse.core.runtime.CoreException[0]: java.io.FileNotFoundException: 
http://update.eclipse.org/updates/plugins/org.eclipse.help.webapp_2.0.0.jar
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream
(HttpURLConnection.java:595)
	at java.net.HttpURLConnection.getResponseCode
(HttpURLConnection.java:260)
	at org.eclipse.update.core.ContentReference.getInputSize
(ContentReference.java:145)
	at org.eclipse.update.core.FeatureContentProvider.asLocalReference
(FeatureContentProvider.java:113)
	at 
org.eclipse.update.internal.core.FeaturePackagedContentProvider.getPluginEntryAr
chiveReferences(FeaturePackagedContentProvider.java:220)
	at org.eclipse.update.core.Feature.install(Feature.java:291)
	at org.eclipse.update.internal.core.SiteFile.install(SiteFile.java:70)
	at org.eclipse.update.internal.core.ConfiguredSite.install
(ConfiguredSite.java:208)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.executeOneJob
(NewUpdatesWizard.java:143)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.execute
(NewUpdatesWizard.java:134)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.access$2
(NewUpdatesWizard.java:129)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard$1.run
(NewUpdatesWizard.java:93)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run
(ModalContext.java:98)
!ENTRY org.eclipse.update.core 4 0 May 29, 2002 12:08:41.329
!MESSAGE Error retrieving plugins/org.eclipse.help.webapp_2.0.0.jar in Archive 
Reference No Reference at location 
http://update.eclipse.org/updates/features/org.eclipse.platform_2.0.0.2002052711
01.jar. Unable to access plugins/org.eclipse.help.webapp_2.0.0.jar.
[java.io.FileNotFoundException: 
http://update.eclipse.org/updates/plugins/org.eclipse.help.webapp_2.0.0.jar]
!STACK 0
java.io.FileNotFoundException: 
http://update.eclipse.org/updates/plugins/org.eclipse.help.webapp_2.0.0.jar
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream
(HttpURLConnection.java:595)
	at java.net.HttpURLConnection.getResponseCode
(HttpURLConnection.java:260)
	at org.eclipse.update.core.ContentReference.getInputSize
(ContentReference.java:145)
	at org.eclipse.update.core.FeatureContentProvider.asLocalReference
(FeatureContentProvider.java:113)
	at 
org.eclipse.update.internal.core.FeaturePackagedContentProvider.getPluginEntryAr
chiveReferences(FeaturePackagedContentProvider.java:220)
	at org.eclipse.update.core.Feature.install(Feature.java:291)
	at org.eclipse.update.internal.core.SiteFile.install(SiteFile.java:70)
	at org.eclipse.update.internal.core.ConfiguredSite.install
(ConfiguredSite.java:208)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.executeOneJob
(NewUpdatesWizard.java:143)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.execute
(NewUpdatesWizard.java:134)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.access$2
(NewUpdatesWizard.java:129)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard$1.run
(NewUpdatesWizard.java:93)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run
(ModalContext.java:98)
!SUBENTRY 1 org.eclipse.update.core 4 0 May 29, 2002 12:08:41.359
!MESSAGE Error retrieving plugins/org.eclipse.help.webapp_2.0.0.jar in Archive 
Reference No Reference at location 
http://update.eclipse.org/updates/features/org.eclipse.platform_2.0.0.2002052711
01.jar. Unable to access plugins/org.eclipse.help.webapp_2.0.0.jar.
[java.io.FileNotFoundException: 
http://update.eclipse.org/updates/plugins/org.eclipse.help.webapp_2.0.0.jar]
!STACK 0
java.io.FileNotFoundException: 
http://update.eclipse.org/updates/plugins/org.eclipse.help.webapp_2.0.0.jar
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream
(HttpURLConnection.java:595)
	at java.net.HttpURLConnection.getResponseCode
(HttpURLConnection.java:260)
	at org.eclipse.update.core.ContentReference.getInputSize
(ContentReference.java:145)
	at org.eclipse.update.core.FeatureContentProvider.asLocalReference
(FeatureContentProvider.java:113)
	at 
org.eclipse.update.internal.core.FeaturePackagedContentProvider.getPluginEntryAr
chiveReferences(FeaturePackagedContentProvider.java:220)
	at org.eclipse.update.core.Feature.install(Feature.java:291)
	at org.eclipse.update.internal.core.SiteFile.install(SiteFile.java:70)
	at org.eclipse.update.internal.core.ConfiguredSite.install
(ConfiguredSite.java:208)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.executeOneJob
(NewUpdatesWizard.java:143)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.execute
(NewUpdatesWizard.java:134)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard.access$2
(NewUpdatesWizard.java:129)
	at org.eclipse.update.internal.ui.wizards.NewUpdatesWizard$1.run
(NewUpdatesWizard.java:93)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run
(ModalContext.java:98)
Comment 1 Dave Thomson CLA 2002-05-29 12:03:26 EDT
Created attachment 1101 [details]
Bitmap showing error
Comment 2 Vlad Klicnik CLA 2002-05-29 14:28:04 EDT
Able to recreate.

The root cause is the fact that in the current builds the help.webapp plugin has 
a problem and is not being successfully built. So the platform feature is 
referencing a plugin jar that does not exist. 

I have played with this scenario (trying to simulate a frustrated user just 
clicking on things) and I got myself into a progressively worse state. The 
scenario is reproducible with Nevada as it exists right now (200205271101 build 
being the latest .... may need to grab this build and setup in a controlled site 
until we get this debugged).

Steps I followed:

* start up brand new 0528
* Help> Software Updates> New Updates
* all is well until the last feature (base platform), fails because of the 
missing webapp plugin

Problem 1: bugus error message (as pointed out by Dave)

* I clicked OK on the error dialog, and Cancel in the wizard

Problem 2: I should not have to explicitly cancel the wizard. I should either be 
offered to continue installing the next available update (ie. only skip the bad 
one) or stop installing at that point. At this point we have installed 
updates to the features preceeding the error (the one in error is backed out). 
We should probably ask the user whether to "accept" (configure) the partial 
updates, or not.

* I was offered to restart, OK
* eclipse restarted and I was told I had new changes

Problem 3: this is bogus - should not have changes as a result of one-click. 
This likely caused because we did not harden our state after the failure.

* I selected not to apply the changes
* open update manager .... current configuration is OK given the above problems 
(original feature versions configured, new ones not - see Problem 2/3)
* Help> Software Updates> New Updates .... do one-click again
* wizard found same features I need based on the original configured features
* Finish .... start installing, and immediately fail because feature.xml for 
jdt.source already exists

Problem 4: we should recognize we already have the feature installed. I suspect 
we are checking for configured features, but in this scenario the new version is 
not configured. We have 2 choices ... either detect this, or allow the 
unconfigured feature to be overwritten (but never configured feature).

* now the fun started ... I clicked OK on the error dialog, and clicked [Finish] 
again. This time it looked like jdt.source installed (quickly because we have 
the plugins) and I failed on the next feature (jdt) with the error saying 
feature.xml exists
* [Finish] again .... fail on jdt.source again (first install)
* [Finish] again .... this time jdt.source and jdt looked OK, but failed on pde 
(same error)
* I cancelled the wizard, ad declined to restart when prompted.
* Opened Update manager, current configuration is showing the new version of jdt 
and jdt.source (SDK) with warnings (2.0.0 plugins are running)
* I restarted eclipse, go to update manager
* now jdt and jdt.source (SDK) are showing the original version (OK) BUT PDE has 
a warning (showing 2.0.0 feature configured, but new versions of plugins are 
running)
* there is no PDE feature in the features/ directory, so its new plugins are 
being picked up as unmanaged

Problem 5: repeated clicking on [Finish] is not handled ... need to either fix, 
or never get ourselves into this situation of keeping the wizard open after 
error (Problem 2)

Will attach zip of the workspace (.log, .config)




Comment 3 Vlad Klicnik CLA 2002-05-29 14:34:00 EDT
Created attachment 1105 [details]
workspace (forgot to mention in steps I deleted the delta so is not in the zip)
Comment 4 Christophe Elek CLA 2002-05-29 16:50:36 EDT
The feature already installed issue should be solved by bug 18021
Comment 5 Christophe Elek CLA 2002-05-29 19:23:48 EDT
Created attachment 1114 [details]
New Message if a file is remotely missing [GIF]
Comment 6 Christophe Elek CLA 2002-05-29 19:25:09 EDT
Code in version 20020529H1945_18021
Comment 7 Vlad Klicnik CLA 2002-05-30 14:23:26 EDT
I have setup up an internal site that has the content off Nevada with 
200205271101 as the latest build (pre-nesting, missing a plugin).

http://klicnik.torolab.ibm.com/shrek/NevadaTestSite/

Am attaching a zip of the corresponding feature definitions that you need to run 
with (update URL points to the internal site).
Comment 8 Vlad Klicnik CLA 2002-05-30 14:24:19 EDT
Created attachment 1123 [details]
"flat" features with update URL pointing to shrek
Comment 9 Dejan Glozic CLA 2002-05-30 22:12:13 EDT
By reading the bug, I completely lost track what needs to be done here on the 
part of UI. Help?
Comment 10 Vlad Klicnik CLA 2002-05-31 15:32:36 EDT
"Problem 2" and "Problem 3" in my original post to the defect remain. Target for 
F2.
Comment 11 Dejan Glozic CLA 2002-05-31 19:08:54 EDT
Implemented.