Bug 181718 - [results] Comment not displayed in perf result
Summary: [results] Comment not displayed in perf result
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3.2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, test
: 207578 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-04-10 04:41 EDT by Jerome Lanneluc CLA
Modified: 2008-09-19 04:27 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (10.45 KB, patch)
2008-02-01 12:13 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2007-04-10 04:41:46 EDT 
I20070403-1110

If you look at the following test:
/downloads/drops/I20070403-1110/performance/eclipseperflnx1_R3.3/org.eclipse.jdt.core.tests.performance.FullSourceWorkspaceModelTests.testSeekPackageFragments().html
you'll see that its comment is not displayed.

However this test has the following line: setComment(Performance.EXPLAINS_DEGRADATION_COMMENT, "Test has been rewritten and is not stabilized yet...");
Comment 1 Kim Moir CLA 2007-04-10 17:39:06 EDT 
The scenario must be part of the fingerprint for the comment to be displayed, I think this is the issue.
Comment 2 Kim Moir CLA 2007-04-12 18:00:36 EDT 
moving back to jdt core to add test to fingerprint if desired
Comment 3 Jerome Lanneluc CLA 2007-04-13 06:35:40 EDT 
I'm not sure why there is such restriction. We don't want to put the test in the fingerprint, still we would like to see the comment in the test result.
Comment 4 Frederic Fusier CLA 2007-11-12 10:57:47 EST 
*** Bug 207578 has been marked as a duplicate of this bug. ***
Comment 5 Frederic Fusier CLA 2008-02-01 12:13:53 EST 
Created attachment 88602 [details]
Proposed patch

Fix consists in create an "special" summary entry storing only the comment and associates it with the appropriate scenario. To avoid taking this scenario as a fingerprint one, the dim id is set to 0 (which is not possible in normal case).
Comment 6 Frederic Fusier CLA 2008-02-01 12:27:58 EST 
Released for 3.4M5 in HEAD stream.
Comment 7 Frederic Fusier CLA 2008-02-06 06:09:50 EST 
Verified using perf results of M20080205-1130 build.