Bug 18085 - Using "h" mnemonic in file or java search page switches to Help page
Summary: Using "h" mnemonic in file or java search page switches to Help page
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 normal (vote)
Target Milestone: 2.0 F3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
: 18865 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-05-28 14:19 EDT by Konrad Kolosowski CLA
Modified: 2002-06-13 04:23 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Kolosowski CLA 2002-05-28 14:19:34 EDT 
I have fixed bug 16546, and added letter "h" mnemonic for help search tab in 
the search dialog.
However, while using file or java search that define "h" mnemonic for 
the "Choose..." button, pressing "h" causes a page to be switched to help 
search, instead of activating the choose button.  This seems like a bad 
handling of mnemonics by the ui, but it is not likely that it will change in 
2.0.

To fix search dialod, we would rather leave "H" on the sarch tab to mean Help, 
as it means in the menus and other places.
Could you change the mneumonic for the choose buttons to something else 
like "o"?  This would eliminate the conflict.
Thanks
Comment 1 Erich Gamma CLA 2002-05-30 08:39:04 EDT 
There is a deeper problem. Given that the Search dialog can be extended by 
other tabs it is almost impossible to achive uniqueness of mnemonics in tab 
items.

I therefore suggest to not add any mnemonics to the tab folders in such a 
dialog. Notice, that the tabs are still accessible using 1) the global Search 
menu (Search>Java), 2)you can tab to the tab items using the TAB key

Asking Nick for the blessing of this approach
Comment 2 Dani Megert CLA 2002-05-30 13:31:23 EDT 
I removed the mnemonics - please veto if not ok.
Comment 3 Dani Megert CLA 2002-05-30 13:33:41 EDT 
Actually I reopen the PR, revert and wait for Nick's OK since Help is also affected.
Once the OK is here I'll move the PR to the Help component.
Comment 4 Nick Edgar CLA 2002-05-31 21:29:53 EDT 
Removing them is correct.  Should not have mnemonics on parts in the main 
window except for menus for exactly this reason.
(See the accessibility tips off of our team development resources page).

Dejan, PDE still has this issue too.  For example, some of the plugin.xml 
editor's buttons have mnemonics.
Comment 5 Dejan Glozic CLA 2002-05-31 22:39:11 EDT 
I thought I removed these mnemonics?
Comment 6 Konrad Kolosowski CLA 2002-05-31 22:40:51 EDT 
I have removed mnemonic from Help Search tab (for F2 build)
Daniel, you can close this bug once you are done with your pages.
Comment 7 Nick Edgar CLA 2002-06-01 12:35:10 EDT 
Dejan, the Extensions page of the plugin.xml editor still has &Delete, &Apply 
and &Reset in 0601.  Should check all pages of all PDE editors.
Comment 8 Dani Megert CLA 2002-06-03 04:07:53 EDT 
File Search, Java Search and NLS Keys will be changed for F3.
Comment 9 Nick Edgar CLA 2002-06-03 09:25:13 EDT 
I've filed bug 18702 for PDE.
Comment 10 Konrad Kolosowski CLA 2002-06-03 15:10:00 EDT 
*** Bug 18865 has been marked as a duplicate of this bug. ***
Comment 11 Dani Megert CLA 2002-06-06 06:17:28 EDT 
Fixed in build 20020606
Reviewed by AK
Comment 12 Dirk Baeumer CLA 2002-06-13 04:23:43 EDT 
Verified. TB