Bug 180693 - [WorkbenchLauncher] "untitled window" while starting Eclipse
Summary: [WorkbenchLauncher] "untitled window" while starting Eclipse
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux-GTK
: P3 trivial (vote)
Target Milestone: 3.3 RC4   Edit
Assignee: Andrew Niefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 179053 (view as bug list)
Depends on: 191072
Blocks:
  Show dependency tree
 
Reported: 2007-04-03 07:46 EDT by Tomasz Zarna CLA
Modified: 2007-08-01 03:25 EDT (History)
5 users (show)

See Also:
jeffmcaffer: pmc_approved+
tjwatson: review+
simon_kaegi: review+
steve_northover: review+


Attachments
Screen shot (211.78 KB, image/png)
2007-04-03 07:46 EDT, Tomasz Zarna CLA
no flags Details
patch (852 bytes, patch)
2007-05-23 10:18 EDT, Andrew Niefer CLA
no flags Details | Diff
binaries (30.50 KB, application/octet-stream)
2007-05-23 10:18 EDT, Andrew Niefer CLA
no flags Details
Screen shot 2 (233.01 KB, image/png)
2007-06-07 03:45 EDT, Dani Megert CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2007-04-03 07:46:28 EDT
Build ID: I20070327-0800

Steps To Reproduce:
While launching Eclipse the title bar says "untitled window" in a bottom panel. It should stay with "Eclipse" until starting process isn't completed.
Comment 1 Tomasz Zarna CLA 2007-04-03 07:46:57 EDT
Created attachment 62766 [details]
Screen shot
Comment 2 Kim Horne CLA 2007-04-03 11:43:38 EDT
Andrew:  I could set this once we come up but is there any way to set it earlier?  As soon as you open the shell perhaps?
Comment 3 Andrew Niefer CLA 2007-04-03 11:56:46 EDT
I'm sure I should be able to set the window title natively.
Comment 4 Tomasz Zarna CLA 2007-05-23 05:21:38 EDT
Bug 179053 looks like a dupe.
Comment 5 Kim Horne CLA 2007-05-23 08:16:57 EDT
I'm guessing this should probably be fixed in the native launcher but I'm not sure we have sufficient information at that point.  We can't simply call the window Eclipse because that will affect RCP developers.  I could set the title on the shell to be the same name we pull out for the About menu but I dont come along until late in the startup cycle.  Opinions Andrew?
Comment 6 Andrew Niefer CLA 2007-05-23 09:38:26 EDT
*** Bug 179053 has been marked as a duplicate of this bug. ***
Comment 7 Andrew Niefer CLA 2007-05-23 10:16:53 EDT
The launcher takes the name from the executable that launched it.  This works if the java vm was started in-process.  If java was forked then we don't currently have a name to put up.
Comment 8 Andrew Niefer CLA 2007-05-23 10:18:13 EDT
Created attachment 68339 [details]
patch
Comment 9 Andrew Niefer CLA 2007-05-23 10:18:48 EDT
Created attachment 68340 [details]
binaries

recompiled with patch for testing
Comment 10 Andrew Niefer CLA 2007-05-23 10:38:23 EDT
After some testing, it seems this patch is not strictly necessary.
Andrew, Tomasz, can you please try with RC1.  I believe this may be fixed indirectly by changes for bug 185936.  That is you get either the name of the eclipse executable or nothing (not untitled) depending on how the vm was started.
Comment 11 Tomasz Zarna CLA 2007-05-24 04:11:09 EDT
Sorry, I'm able to reproduce it with both I20070517-1700 (3.3RC1) and I20070523-0010. A window titled "untitled window" still appears in window list applet. Is there any extra information I can provide to help you with this bug?
Comment 12 Andrew Niefer CLA 2007-05-24 09:32:50 EDT
Thomasz, I need to decide if this is the same as bug 174187.  What happens if you try the binaries that are attached to this bug.  (the .so file goes in the launcher.gtk.linux.x86 fragment in the plugins directory).

Also how is your vm being started:  If you go to Help->About->Configuration Details, look for the -vm that is part of the eclipse.commands property, does it point to a java executable or to a libjvm.so file?
Comment 13 Tomasz Zarna CLA 2007-05-24 10:53:47 EDT
I replaced the .so file from the fragment with the one from the attachment and restarted Eclipse. Unfortunately, I can see no difference :/

I belive this part of my configuration details will answer your second question:

*** System properties:
eclipse.buildId=I20070523-0010
eclipse.commands=-os
linux
-ws
gtk
-arch
x86
-showsplash
/home/tzarna/eclipse-SDK-I20070523-0010-linux-gtk//plugins/org.eclipse.platform_3.3.0.v20070419/splash.bmp
-launcher
/home/tzarna/eclipse-SDK-I20070523-0010-linux-gtk/eclipse
-name
Eclipse
--launcher.library
/home/tzarna/eclipse-SDK-I20070523-0010-linux-gtk/plugins/org.eclipse.equinox.launcher.gtk.linux.x86_1.0.0.v20070516/eclipse_1017.so
-startup
/home/tzarna/eclipse-SDK-I20070523-0010-linux-gtk/plugins/org.eclipse.equinox.launcher_1.0.0.v20070516.jar
-vm
/usr/java/jdk1.5.0_08/bin/../jre/lib/i386/client/libjvm.so
eclipse.ee.install.verify=false
eclipse.product=org.eclipse.sdk.ide
eclipse.startTime=1180043221112
eclipse.vm=/usr/java/jdk1.5.0_08/bin/../jre/lib/i386/client/libjvm.so
eclipse.vmargs=-Xms40m
-Xmx256m
-Djava.class.path=/home/tzarna/eclipse-SDK-I20070523-0010-linux-gtk/plugins/org.eclipse.equinox.launcher_1.0.0.v20070516.jar
eof=eof
file.encoding=UTF-8
(...)
Comment 14 Andrew Niefer CLA 2007-06-05 15:46:59 EDT
we should set the title explicitly.  bug 191072 is the change to untitled
Comment 15 Andrew Niefer CLA 2007-06-05 17:24:25 EDT
To clarify, bug 190616 fixes the "untitled window".  This patch fixes the problem where we are not setting the proper title.  We should be setting the title to be the official name (specified with -name).  Currently the title is just the name of executable (or if a link was used, potentially the name of the link).
Comment 16 Andrew Niefer CLA 2007-06-06 10:17:14 EDT
(In reply to comment #15)
> To clarify, bug 190616 fixes the "untitled window".
This was a typo, I meant bug 191072.
Steve, does this get a +1?
Comment 17 Steve Northover CLA 2007-06-06 13:27:01 EDT
I could have swore I already checked the patch and +1'd it.  Was there another bug with the same patch?
Comment 18 Andrew Niefer CLA 2007-06-06 14:34:14 EDT
done in head.  I'm not sure what you would have looked at Steve unless it was the x86 vs ppc bug that I accidently referred to above 190616
Comment 19 Dani Megert CLA 2007-06-07 03:43:39 EDT
Was this released into I20070607-0010? If so, this is not fixed, see attached Screen shot 2.
Comment 20 Dani Megert CLA 2007-06-07 03:45:10 EDT
Created attachment 70471 [details]
Screen shot 2
Comment 21 Andrew Niefer CLA 2007-06-07 09:36:10 EDT
Daniel, this bug had the fix that the task bar was not showing the proper official name, bug 191072 is about the change to "untitled window".

If you start with "eclipse -name MYNAME" then you should expect to see MYNAME in the task bar.  If it changes to untitled window then it is bug 191072 that is not fixed.

Note that both of these are working for me when I try I20070607-0010.
If there is no name at all, that is bug 174187.
Comment 22 Steve Northover CLA 2007-06-07 09:40:28 EDT
Could it be a window manager thing?
Comment 23 Dani Megert CLA 2007-06-08 08:27:19 EDT
It's bug 174187 I'm seeing. Reopening this one happened by mistake. Sorry.
Comment 24 Dani Megert CLA 2007-06-08 09:12:46 EDT
Mmmh. Even if I use -name foo it doesn't work. Not even on Windows XP. See bug 191072 comment 9.
Comment 25 Tomasz Zarna CLA 2007-08-01 03:25:19 EDT
I tried out the I20070724-0800 build and it worked for me. I followed the steps below:
1. Downloaded the I-build
2. Started Eclipse by clicking on the executable "eclipse" file. 

Instead of the "untitled window" title I'm getting "Eclipse" now. So, I assume I can mark this particular bug as verified.