Bug 180504 - [Viewers] (Table|Tree)EditorImpl#applyEditorValue is not robust against table/tree being disposed
Summary: [Viewers] (Table|Tree)EditorImpl#applyEditorValue is not robust against table...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-02 11:46 EDT by Andrzej Cichocki CLA
Modified: 2008-02-06 15:22 EST (History)
1 user (show)

See Also:

Attachments
RCP application that demonstrates the problem (72.20 KB, application/x-zip)
2007-04-02 12:20 EDT, Andrzej Cichocki CLA 		no flags Details
Patch (15.53 KB, patch)
2007-09-25 11:05 EDT, Thomas Schindl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrzej Cichocki CLA 2007-04-02 11:46:48 EDT 
Build ID: M20070212-1330

Steps To Reproduce:

1. Run the attachment as an Eclipse RCP application.
2. Open 1 editor using the button provided. This also opens the error log view.
3. Click into the cell editor in the editor.
4. Press enter to commit the cell editor.

A dialog pops up and an error is logged.

On commit, the cell editor is disposing its parent table. The subsequent JFace code in (Table|Tree)EditorImpl#applyEditorValue causes the logged SWTException. It should cope with the disposed state of the table/tree gracefully instead of causing the exception.
Comment 1 Andrzej Cichocki CLA 2007-04-02 12:20:32 EDT 
Created attachment 62675 [details]
RCP application that demonstrates the problem
Comment 2 Thomas Schindl CLA 2007-09-25 11:05:01 EDT 
Created attachment 79133 [details]
Patch

fix + test-case, Boris should i take care about this?
Comment 3 Thomas Schindl CLA 2007-12-12 14:44:23 EST 
missed the M4 cut
Comment 4 Thomas Schindl CLA 2007-12-19 09:41:50 EST 
released to CVS HEAD > 20071219
Comment 5 Thomas Schindl CLA 2008-02-06 15:22:42 EST 
verified by codeinspection because test succeeded in I20080205