Bug 180482 - Synchronize view sometimes goes deafult color when ctrl adding files
Summary: Synchronize view sometimes goes deafult color when ctrl adding files
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.3 RC4   Edit
Assignee: Steve Northover CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-02 09:32 EDT by Peter Larsen CLA
Modified: 2007-06-04 23:13 EDT (History)
5 users (show)

See Also:
john.arthorne: review+


Attachments
Shows the color after minimazing/maximazing (40.63 KB, image/jpeg)
2007-04-02 09:34 EDT, Peter Larsen CLA
no flags Details
patch (1016 bytes, patch)
2007-06-04 17:08 EDT, Silenio Quarti CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Larsen CLA 2007-04-02 09:32:52 EDT
Build ID: I20070323-1616

Steps To Reproduce:
1) Goto Tream Synchronize 
2) Synchronize - with some outgoing changes
3) Ctrl select some files.

The view goes all deault color execpt those files choosen. 
After minimizing/maximazing all files are visiable again
but the color is still wrong.

This happens for me once a week, but I have found no reproducable way.
Comment 1 Peter Larsen CLA 2007-04-02 09:34:03 EDT
Created attachment 62658 [details]
Shows the color after minimazing/maximazing

The background should be all white here.
Comment 2 Michael Valenta CLA 2007-04-10 14:03:51 EDT
Sounds like a problem at the widget level. Moving to SWT for comment.
Comment 3 Steve Northover CLA 2007-04-18 00:34:01 EDT
I saw this once after running Eclipse 3.3 M6 for a week or so.  Silenio saw this the other day.  Can anybody get repeatable steps?  It happened after we had taken some Microsoft automatic updates (but this probably has nothing to do with it).

Peter, did you recently take XP updates from Microsoft?
Comment 4 Peter Larsen CLA 2007-04-24 07:38:13 EDT
> Peter, did you recently take XP updates from Microsoft?

Yes. The machine is nearly allways updated.

> Can anybody get repeatable steps?

I could when i looked at it last time reproduce 
it 25% times by having 2 outgoing files, A and B. 
Double click on A.
(fast after)Double clock on B.
Wait 10 sec. (critacal times seems 7 sec)
ctlr-dooble click on A.

e.i. I happens for me when I am looking through outgoing 
files too se if it is in order - the last file needs a 
closer look and then I start including the files to be committed.

It may be corrolated to the full file name "popup" when 
the view is too narrow.
Comment 5 Steve Northover CLA 2007-05-31 17:38:35 EDT
Looking at this one for 3.3 RC3.  I've seen it recently in the CVS view but not in the Synchronize view.  Can anyone confirm this?

The CVS view expands nodes when you single click select them (why?) and I have a theory that the bug is related to this.  The Synchronize view doesn't do this but might have in the past.

Anything more?
Comment 6 Steve Northover CLA 2007-06-01 10:38:31 EDT
I also have a theory that you must be extending a multi-selection in the tree using Ctrl+Click.  Can anyone confirm this?

Guys, this is a hard one and looks terrible.  It happens very rarely.  A repeatable case is needed (and any information you can give me).
Comment 7 Steve Northover CLA 2007-06-01 17:05:44 EDT
Marking as 3.3 RC4.  There is a strong chance we won't fix this.
Comment 8 Peter Larsen CLA 2007-06-03 09:55:45 EDT
I can reproduce this every time now in rc3, but the timing is still important. 
2 outgoing files are needed and in synchronize view.

1) Close all tabs in the editor-/view/space?.
2) Double click on A
3) wait 3-4 seconds
4) ctrl-double click on B

I can reproduce this every time if step 3 between 2 sec and 7 sec. What is strange is that focus in the diffs tabs jumps from A to the created B (as expected) and then back to A at once when I do step 4.

Peter
Comment 9 Silenio Quarti CLA 2007-06-04 17:06:22 EDT
Here is simple test that reproduces the problem. Run it and when the window comes up. Select a new item in the tree by clicking and holding the left mouse button with the CONTROL key pressed.

import org.eclipse.swt.*;
import org.eclipse.swt.layout.*;
import org.eclipse.swt.widgets.*;

public class PR180482 {
public static void main(String[] args) {
	final Display display = new Display();
	final Shell shell = new Shell(display);
	
	shell.setLayout(new FillLayout());
	Button b = new Button(shell, SWT.PUSH);
	b.setText("&text");
	
	final Tree tree = new Tree(shell, SWT.MULTI);
	
	for (int i = 0; i < 10; i++) {
		TreeItem item = new TreeItem(tree, SWT.NONE);
		item.setText("Item" + i);
	}
	tree.addListener(SWT.DragDetect, new Listener() {
		public void handleEvent(Event event) {
		}
	});
	tree.setSelection(tree.getItem(2));
	
	shell.layout(true, true);
	
	tree.addListener(SWT.Activate, new Listener() {
		public void handleEvent(Event event) {
			System.out.println("here");
			tree.setFocus();
		}
	});
	
	shell.open();
	while (!shell.isDisposed()) {
		if (!display.readAndDispatch()) display.sleep();
	}
}
}
Comment 10 Silenio Quarti CLA 2007-06-04 17:08:58 EDT
Created attachment 70038 [details]
patch
Comment 11 Felipe Heidrich CLA 2007-06-04 17:28:26 EDT
I verified the snippet and the patch on Windows XP and Windows Vista.

+1 for RC4
Comment 12 Steve Northover CLA 2007-06-04 17:52:55 EDT
+ for 3.3 RC4
Comment 13 John Arthorne CLA 2007-06-04 17:54:20 EDT
+1
Comment 14 Felipe Heidrich CLA 2007-06-04 17:56:03 EDT
fixed in HEAD > 20070604
The fix released is SSQ's patch attached in comment #10
Comment 15 Carolyn MacLeod CLA 2007-06-04 23:13:26 EDT
The fix will be in the 20070605-0010 build.