Community
Participate
Working Groups
Build ID: HEAD as of 3/31/2007 In the Apply Patch wizard, each time I type a character in the filename field, the cursor jumps to the beginning of the field. Thus, if I want to type in a path, I have to press the "End" key after each character so that the next one is added at the end of the field. This makes the field almost unusable for manual entry of a path. I found the cursor only jumps the first time the given path is typed on the current run of the Apply Patch wizard. The cursor doesn't jump after a path is selected with Browse, and selecting a path with Browse does not stop the cursor from jumping if the same path is later typed in manually. It doesn't matter whether the file named by the path exists. Steps To Reproduce: 1. Right-click a resource -> Team -> Apply Patch. 2. Press the File radio button. 3. Click in the filename text field and type something.
Created attachment 62591 [details] Fix by not calling setSourceName when text field is selected I debugged and found the following: Typing into the text field causes a widget selected event. That event activates the listener at line 377 of InputPatchPage, which calls setSourceName to ensure that the new path is in the drop-down history list. If the path is not already present, it is added. (This is why the cursor only jumps the first time a given path is typed.) Adding the path involves temporarily clearing the text field, which I imagine makes the cursor jump. I don't understand why typing causes a selected event but clicking in the text field doesn't. Maybe the bogus selected event is at fault. On the other hand, I don't see why it's important to call setSourceName to add the path to the history list. Simply deleting the call (as in this patch) seems to fix the bug.
Thanks for the patch
Patch released to HEAD. Thanks again.
Verified
