Bug 179831 - [Intro] Model is reloaded when Go To Workbench is pressed
Summary: [Intro] Model is reloaded when Go To Workbench is pressed
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-03-28 16:02 EDT by Chris Goldthorpe CLA
Modified: 2007-12-18 18:54 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2007-03-28 16:02:01 EDT
3.3M6

I ran into this when debugging.

Set a breakpoint in ExtensionPointManager.loadCurrentModel()
It will be hit once when the Intro is first displayed and once more when you press Go To Workbench. This is because CustomizableIntroPart.dispose()is causing the cached model to be deleted, forcing it to be reread to create the toolbar.
Comment 1 Chris Goldthorpe CLA 2007-03-28 16:04:14 EDT
Targeting 3.3, we really should fix this.
Comment 2 Dave Resch CLA 2007-03-28 17:29:25 EDT
Chris,

Not sure if this is related, but I've found a problem switching between launch bar and intro view. 

Result is occasional NPEs with the message, "Unable to create view ID org.eclipse.ui.internal.introview: An unexpected exception was thrown." The triggering event is always a button click on the launch bar.

This problem seems somehow related to using the label attribute in the <intro> element in org.eclipse.ui.intro extension. When my intro plug-in uses the label attribute, NPEs occur more frequently, sometimes even when the intro first attempts to open, immediately after application launch.

BTW, this is a non-universal intro, using CustomizableIntroPart and declaring its own org.eclipse.ui.intro.config extension.

You think there might be a connection?
Comment 3 Chris Goldthorpe CLA 2007-03-28 17:40:46 EDT
I don't know if your NPE is related, it could well be a different bug.

Can you do a bugzilla search for 

[Intro] NPE

to see if your problem has already been reported (I saw 6 matches). If not can you file a new bug report including the stack trace. 
Comment 4 Chris Goldthorpe CLA 2007-05-08 14:32:30 EDT
Although this is a performance issue it is not a regression. I think that there is risk involved in fixing this bug at this stage in the release cycle so have removed the target milestone of 3.3.
Comment 5 Chris Goldthorpe CLA 2007-12-18 18:54:23 EST
Fixed in HEAD