Bug 179659 - [plan] - Implementation of tar support
Summary: [plan] - Implementation of tar support
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Geclipse (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Markus Knauer CLA
QA Contact: Mathias Stümpert CLA
URL:
Whiteboard:
Keywords: contributed, plan
: 178539 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-03-28 03:59 EDT by Mathias Stümpert CLA
Modified: 2014-01-09 16:18 EST (History)
2 users (show)

See Also:


Attachments
Tar package patch (33.09 KB, patch)
2007-05-15 13:04 EDT, Ariel Garcia CLA
aog-ecl: iplog+
Details | Diff
Small additional patch to apply after the first one (1.87 KB, patch)
2007-05-19 16:24 EDT, Ariel Garcia CLA
aog-ecl: iplog+
Details | Diff
Test class for the TarEntry class (11.05 KB, patch)
2007-05-19 16:34 EDT, Ariel Garcia CLA
aog-ecl: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Stümpert CLA 2007-03-28 03:59:57 EDT
Support for tar archives will be added in order to get rid of the dependency of the core to the ice package.
Comment 1 Mathias Stümpert CLA 2007-03-28 09:13:04 EDT
*** Bug 178539 has been marked as a duplicate of this bug. ***
Comment 2 Markus Knauer CLA 2007-05-02 09:45:35 EDT
Moving to M4 - while it is not top priority it is important to remove this external dependency from the core.

I'm taking over...
Comment 3 Ariel Garcia CLA 2007-05-15 13:02:17 EDT
Here the patch i wrote adding a  eu.geclipse.core.util.tar  package, implemented from scratch based on the tar-format documentation. The implementation is minimal in the sense that only the functionality we require is implemented (untar'ing standard tar files). I guess later we will need to add support for creating tar files for grid-deployment tasks.

The patch has been tested to work with the CA certificates. Test package will follow.
Comment 4 Ariel Garcia CLA 2007-05-15 13:04:51 EDT
Created attachment 67278 [details]
Tar package patch

I just noticed that you will get a conflict on the core Solutions class, because i externalized a couple of solution messages which Mathias added.
Comment 5 Ariel Garcia CLA 2007-05-15 13:07:07 EDT
A side comment: the com.ice.tar source code is completely free, public domain  ;-)  so we could have kept it and integrated it.
 
Comment 6 Ariel Garcia CLA 2007-05-19 16:24:33 EDT
Created attachment 67904 [details]
Small additional patch to apply after the first one

This small patch adds support for tar files created by some client (non-gnu?) where octal values in the header are not left padded with 0's.
Comment 7 Ariel Garcia CLA 2007-05-19 16:34:04 EDT
Created attachment 67905 [details]
Test class for the TarEntry class

This patch adds a TarEntry_PDETest test class. It is a PDE test because it requires the Exception functionality provided by GridException. This is needed to be able to fully test that the class works correctly (see  testTarEntry_invalidHeaders(), where the TarEntry constructor is expected to thow an exception if the test will succeed). Suggestions on how to make this a plain (non-pde) test are welcome.
Comment 8 Ariel Garcia CLA 2007-05-20 09:17:46 EDT
NOTE: the test Class patch has the wrong package name: utils -> should be util. Sorry! 
Comment 9 Markus Knauer CLA 2007-06-03 08:34:00 EDT
not yet integrated - moving to RC0
Comment 10 Markus Knauer CLA 2007-06-18 08:06:08 EDT
Patches are integrated, dependency to the tar plugin has been removed.
Comment 11 Markus Knauer CLA 2007-07-12 09:23:58 EDT
already fixed...
Comment 12 Ariel Garcia CLA 2008-05-18 11:35:52 EDT
Closing this one
Comment 13 Mathias Stümpert CLA 2008-08-01 11:14:07 EDT
Now really closing this one.
Comment 14 Ariel Garcia CLA 2009-05-03 08:48:45 EDT
Comment on attachment 67904 [details]
Small additional patch to apply after the first one

Applied by Markus
Comment 15 Ariel Garcia CLA 2009-05-03 08:48:46 EDT
Comment on attachment 67904 [details]
Small additional patch to apply after the first one

Applied by Markus
Comment 16 Ariel Garcia CLA 2009-05-03 08:49:10 EDT
Comment on attachment 67904 [details]
Small additional patch to apply after the first one

Applied by Markus